U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » U++ Library support » U++ Core » Gcc compile option proposal

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: Gcc compile option proposal [message #39101 is a reply to message #39100]

Thu, 14 February 2013 23:01

mirek
Messages: 14267
Registered: November 2005

Ultimate Member

/home/cxl/upp.src/uppsrc/Core/CharSet.h:119:54: warning: '&&' within '||' [-Wlogical-op-parentheses]
inline bool IsAlpha(int c)         { return c >= 'A' && c <= 'Z' || c >= 'a' && c <= 'z'; }
                                            ~~~~~~~~~^~~~~~~~~~~ ~~
/home/cxl/upp.src/uppsrc/Core/CharSet.h:119:54: note: place parentheses around the '&&' expression to silence this warning

Go to hell with this... I am not going to make the code unreadable.

Plus, I have a very intense feeling that even if I would screw the code and added parenthesis in this situation, one or two years later somebody would get a nice idea that there are more needed around c >= 'A' etc...

Mirek

[Updated on: Thu, 14 February 2013 23:07]

Report message to a moderator

[Message index]

		Gcc compile option proposal By: Didier on Thu, 14 February 2013 19:33
		Re: Gcc compile option proposal By: mirek on Thu, 14 February 2013 20:08
		Re: Gcc compile option proposal By: dolik.rce on Thu, 14 February 2013 20:46
		Re: Gcc compile option proposal By: mirek on Thu, 14 February 2013 20:48
		Re: Gcc compile option proposal By: Didier on Thu, 14 February 2013 21:10
		Re: Gcc compile option proposal By: dolik.rce on Thu, 14 February 2013 21:52
		Re: Gcc compile option proposal By: mirek on Thu, 14 February 2013 23:01
		Re: Gcc compile option proposal By: mirek on Thu, 14 February 2013 23:21
		Re: Gcc compile option proposal By: mirek on Thu, 14 February 2013 23:31
		Re: Gcc compile option proposal By: dolik.rce on Fri, 15 February 2013 07:41
		Re: Gcc compile option proposal By: mirek on Fri, 15 February 2013 08:33
		Re: Gcc compile option proposal By: unodgs on Fri, 15 February 2013 11:11
		Re: Gcc compile option proposal By: Didier on Fri, 15 February 2013 17:50
		Re: Gcc compile option proposal By: nlneilson on Sat, 16 February 2013 17:29
		Re: Gcc compile option proposal By: mirek on Sat, 16 February 2013 18:28
		Re: Gcc compile option proposal By: mirek on Sat, 16 February 2013 11:16
		Re: Gcc compile option proposal By: dolik.rce on Sun, 17 February 2013 17:50
		Re: Gcc compile option proposal By: mirek on Fri, 15 February 2013 19:25

Previous Topic:	Request: completion 64 bit support in Draw and Stream
Next Topic:	Core/Rpc and VC 2012

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Aug 04 05:03:30 CEST 2025

Total time taken to generate the page: 0.08132 seconds