Home » U++ Library support » Splitter » Uninitialised value in SplitterFrame  
	
		
		
			| Uninitialised value in SplitterFrame [message #40213] | 
			Wed, 03 July 2013 18:09   | 
		 
		
			
				
				
				
					
						  
						Novo
						 Messages: 1430 Registered: December 2006 
						
					 | 
					Ultimate Contributor  | 
					 | 
		 
		 
	 | 
 
	
		How to reproduce: run reference/DockingExample1 with valgrind. You will get a report below. 
==22097== Conditional jump or move depends on uninitialised value(s)
==22097==    at 0x454D75: Upp::SplitterFrame::SetStyle(Upp::Splitter::Style const&) (FrameSplitter.cpp:123)
==22097==    by 0x454E72: Upp::SplitterFrame::SplitterFrame() (FrameSplitter.cpp:137)
==22097==    by 0x5151FB: Upp::DockWindow::DockWindow() (DockWindow.cpp:1457)
==22097==    by 0x408F84: DockingExample::DockingExample() (main.cpp:32)
==22097==    by 0x4098FC: GuiMainFn_() (main.cpp:103)
==22097==    by 0x63765B: Upp::AppExecute__(void (*)()) (App.cpp:322)
==22097==    by 0x4098C1: main (main.cpp:101)
==22097==  Uninitialised value was created by a stack allocation
==22097==    at 0x4098D8: GuiMainFn_() (main.cpp:102)
  
 
The problem is in code below. 
SplitterFrame& SplitterFrame::SetStyle(const Splitter::Style& s)
{
	if(style != &s) {
		style = &s;
		RefreshLayout();
		Refresh();
	}
	return *this;
}
SplitterFrame::SplitterFrame()
{
	type = LEFT;
	size = size0 = 4;
	minsize = 0;
	sizemin = 0;
	SetStyle(Splitter::StyleDefault());
}
 
 
When constructor of SplitterFrame calls SetStyle() "style" is still unitialized. IMHO, it is safe to set it to NULL in constructor. 
 
Thanks.
		
		
  Regards, 
Novo
		
 |  
	| 
		
	 | 
 
 
 |  
  
 
Goto Forum:
 
 Current Time: Tue Nov 04 00:32:24 CET 2025 
 Total time taken to generate the page: 0.04873 seconds 
 |