U++ forum: Welcome to the forum

Re: Crash on "package organizer" entry [message #49277 is a reply to message #49189]

Mon, 15 January 2018 12:16

mirek
Messages: 14271
Registered: November 2005

Ultimate Member

Well, I think that the correct should be:

void Value::Serialize(Stream& s) {
	RegisterStd();
	dword type;
	if(s.IsLoading()) {
		s / type;
		if(type >= 0x8000000)
			s.LoadError();
		Free();
		int st = type == VOID_V ? VOIDV : type == STRING_V ? STRING : type;
		if(st == STRING)
			s % data;

But that is fundametaly equivalent to current code in release AFAIK.

Now the real problem here seems to be that UppList->Serialize is called (which is Ctrl::Serialize) instead of UppList->SerializeSettings.

It looks like some stuck configuration of Upp:

void PackageEditor::Serialize(Stream& s) {
	int version = 3;
	s / version;
	if(version >= 3) {
		filelist.SerializeSettings(s);
		package.SerializeSettings(s);
	}
	else {
		s % filelist;
		s % package % package;
	}
	SerializePlacement(s);
	if(version >= 1 && version <= 2) {
		Splitter dummy;
		s % dummy % dummy % dummy % dummy % dummy % dummy;
	}
}

- we should be at version 3 now, calling UppList->SerializeSettings.

Anyway, it should not crash either. If you have it in debugger, on what line exactly in Value::Serialize does it crash?

(If it is ASSERT line, does the crash happens on debug mode only?)

Mirek

[Updated on: Mon, 15 January 2018 12:17]

Report message to a moderator