U++ forum: Welcome to the forum

Status & Roadmap

Authors & License

Funding Ultimate++

Search on this site

Search in forums

Home » U++ Library support » U++ MT-multithreading and servers » SSH package for U++ (A feature-rich ilbssh2 wrapper for Ultimate++)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Return to the default flat view

Create a new topic

Submit Reply

Re: SSH package for U++ [message #50119 is a reply to message #50070]

Tue, 31 July 2018 11:07

mirek is currently offline

mirek
Messages: 14265
Registered: November 2005

Ultimate Member

Oblivion wrote on Wed, 11 July 2018 08:35

Hello Mirek,

Quote:

SSH looks pretty reasonable. Can I move to Core/SSH?

Of course!

Quote:
Put(Stream& in, const String& path);

I would expect path to be the first argument here... Do you insist on this order?

That's because I use "[source], [destination]..." order. I'd prefer it stay that way but I don't insist on it. It can be changed.

Whether the "source, target" or "target, source" is more natural is certainly debatable, however please notice that since the dawn of computer languages the custom is to write target = source (also see strcpy etc... Smile

Smile

That said, where handle or path is involved, I would probably like to have it as first parameter always.

Besides, it does not seem to be consistent anyway:
bool Get(SFtpHandle* handle, Stream& out);
bool Put(SFtpHandle* handle, Stream& in);

Now I am only scrathich the surface, mostly being interested in SFTP for now. Anyway, seeing that interface, I would probably like to change following things:

SFtpHandle* -> SFtpHandle - if something is "HANDLE", it should not be a pointer to handle.

Instead of:

auto sftp = session.CreateSFtp();

I would like to have

SFtp sftp(session);

Besides, I know that there is some movement to use 'auto' everywhere, but I strongly disagree with that, ESPECIALLY in reference examples.

More important: I thing I would remove whole bunch of Gets and Puts, leave only handle variant in sftp and then add SFtpStream instead. With methods provided in SFtp, it should be easy to do, and it would mostly remove "source/destination controversy".

Interestingly, it looks like the most important Gets / Puts are missing there

int Get(SFtpHandle h, void *ptr, int size);
bool Put(SFtpHandle h, const void *ptr, int size);

Anyway, it is now moved to Core/SSH and single example is now in reference - that is another issue I have not solved for now, there is a lot of examples and they really make sense, so maybe I will put them gradually to SSH subfolder.

I am giving you write access to Core/SSH and reference.

Mirek

Report message to a moderator

Send a private message to this user

[Message index]

		SSH package for U++ By: Oblivion on Tue, 14 November 2017 21:59
		Re: SSH package for U++ By: Oblivion on Fri, 17 November 2017 22:15
		Re: SSH package for U++ By: Oblivion on Sat, 18 November 2017 15:57
		Re: SSH package for U++ By: Oblivion on Sun, 19 November 2017 18:21
		Re: SSH package for U++ By: Oblivion on Tue, 21 November 2017 00:38
		Re: SSH package for U++ By: koldo on Thu, 23 November 2017 09:07
		Re: SSH package for U++ By: Oblivion on Fri, 24 November 2017 21:03
		Re: SSH package for U++ By: alkema_jm on Sun, 26 November 2017 04:51
		Re: SSH package for U++ By: Oblivion on Sun, 26 November 2017 09:59
		Re: SSH package for U++ By: alkema_jm on Thu, 30 November 2017 23:55
		Re: SSH package for U++ By: alkema_jm on Fri, 01 December 2017 12:33
		Re: SSH package for U++ By: Oblivion on Fri, 01 December 2017 14:35
		Re: SSH package for U++ By: alkema_jm on Sat, 02 December 2017 09:29
		Re: SSH package for U++ By: Oblivion on Sat, 02 December 2017 10:44
		Re: SSH package for U++ By: alkema_jm on Sun, 03 December 2017 08:35
		Re: SSH package for U++ By: alkema_jm on Mon, 04 December 2017 19:01
		Re: SSH package for U++ By: Oblivion on Mon, 04 December 2017 22:46
		Re: SSH package for U++ By: alkema_jm on Fri, 08 December 2017 11:22
		Re: SSH package for U++ By: alkema_jm on Wed, 13 December 2017 17:46
		Re: SSH package for U++ By: Oblivion on Tue, 19 December 2017 14:27
		Re: SSH package for U++ By: Oblivion on Tue, 19 December 2017 14:44
		Re: SSH package for U++ By: Oblivion on Sun, 07 January 2018 22:09
		Re: SSH package for U++ By: koldo on Mon, 08 January 2018 08:27
		Re: SSH package for U++ By: Oblivion on Tue, 09 January 2018 23:15
		Re: SSH package for U++ By: koldo on Wed, 10 January 2018 08:53
		Re: SSH package for U++ By: Oblivion on Fri, 19 January 2018 14:18
		Re: SSH package for U++ By: Oblivion on Sun, 21 January 2018 12:18
		Re: SSH package for U++ By: koldo on Sun, 21 January 2018 16:53
		Re: SSH package for U++ By: Oblivion on Sun, 28 January 2018 12:13
		Re: SSH package for U++ By: Oblivion on Mon, 02 April 2018 23:27
		Re: SSH package for U++ By: Oblivion on Sat, 07 April 2018 16:25
		Re: SSH package for U++ By: Oblivion on Sun, 15 April 2018 00:39
		Re: SSH package for U++ By: Oblivion on Sat, 21 April 2018 08:12
		Re: SSH package for U++ By: Oblivion on Fri, 04 May 2018 22:08
		Re: SSH package for U++ By: Oblivion on Sat, 16 June 2018 19:09
		Re: SSH package for U++ By: mirek on Tue, 10 July 2018 14:37
		Re: SSH package for U++ By: mirek on Tue, 10 July 2018 15:38
		Re: SSH package for U++ By: mirek on Tue, 10 July 2018 15:42
		Re: SSH package for U++ By: Oblivion on Wed, 11 July 2018 08:35
		Re: SSH package for U++ By: mirek on Tue, 31 July 2018 11:07
		Re: SSH package for U++ By: Oblivion on Fri, 03 August 2018 17:34
		Re: SSH package for U++ By: mirek on Fri, 03 August 2018 18:03
		Re: SSH package for U++ By: Oblivion on Fri, 03 August 2018 18:44
		Re: SSH package for U++ By: Oblivion on Tue, 07 August 2018 23:32
		Re: SSH package for U++ By: mirek on Wed, 08 August 2018 10:56
		Re: SSH package for U++ By: Oblivion on Wed, 08 August 2018 11:22
		Re: SSH package for U++ By: mirek on Wed, 08 August 2018 13:28
		Re: SSH package for U++ By: Oblivion on Wed, 08 August 2018 14:16
		Re: SSH package for U++ By: mirek on Thu, 09 August 2018 11:54
		Re: SSH package for U++ By: mirek on Thu, 09 August 2018 12:00
		Re: SSH package for U++ By: Oblivion on Thu, 09 August 2018 16:24
		Re: SSH package for U++ By: mirek on Thu, 09 August 2018 16:49
		Re: SSH package for U++ By: Oblivion on Thu, 09 August 2018 17:03
		Re: SSH package for U++ By: Oblivion on Thu, 09 August 2018 17:59
		Re: SSH package for U++ By: mirek on Thu, 09 August 2018 18:35
		Re: SSH package for U++ By: Oblivion on Sun, 12 August 2018 12:51
		Re: SSH package for U++ By: Oblivion on Thu, 30 August 2018 07:27
		Re: SSH package for U++ By: mirek on Thu, 30 August 2018 09:04
		Re: SSH package for U++ By: Oblivion on Fri, 31 August 2018 00:12
		Re: SSH package for U++ By: Oblivion on Sun, 02 September 2018 21:59
		Re: SSH package for U++ By: Oblivion on Wed, 31 October 2018 11:00
		Re: SSH package for U++ By: Oblivion on Sun, 04 November 2018 19:55
		Re: SSH package for U++ By: Oblivion on Fri, 22 March 2019 17:39

Previous Topic:	WebSockets client in javascript connected to an U++ server sending binary messages
Next Topic:	TURTLE high cpu usage, potential security flaw, and client handling problem

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

PDF

]

Current Time: Tue Jul 08 23:32:54 CEST 2025

Total time taken to generate the page: 0.03493 seconds