U++ forum: Welcome to the forum

Status & Roadmap

Authors & License

Funding Ultimate++

Search on this site

Search in forums

Home » Developing U++ » UppHub » SurfaceCtrl, 3D viewer of Multiple file format and Surface class (Visualise in 3D many 3D file format object and even all Surface object !)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Return to the default flat view

Create a new topic

Submit Reply

Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class [message #54829 is a reply to message #54817]

Sat, 19 September 2020 12:46

Didier is currently offline

Didier
Messages: 736
Registered: November 2008
Location: France

Contributor

koldo wrote on Fri, 18 September 2020 18:52

Dear Didier

As Eigen is a header only library, and the Eigen U++ package functions are not used by SurfaceCtrl. it is not explicitly necessary to include it in this case.
However, maybe it would be interesting to include it anyway in SurfaceCtrl.

Eigen package included in U++ has MPL2 license, that is compatible with U++ BSD, and no GPL/LGPL code is included.
See here. Anyway, to avoid any error, the EIGEN_MPL2_ONLY is now defined.

Maybe the reason of the misunderstanding is that the GPL license file is in Eigen... It will be removed immediately.

Hello Koldo,

You are wright, I saw the COPYING.GPL and COPYING.LGPL files in EIGEN so I supposed there was really GPL code inside ... Happy to hear it isn't the case Smile

Smile

Eigen header is included in Surface/Surface.h : if it isn't used, it shoudn't be included ==> this was the origin of my remark

As for including it in SurfaceCtrl by default : I think this decision should be left to final user: all packages should be kept as light as possible : this saves some trouble from time to time

Quote:

As Eigen is a header only library, and the Eigen U++ package functions are not used by SurfaceCtrl. it is not explicitly necessary to include it in this case.

I am not sure I understand correctly, but eaven if a package is "header only" it should be normally managed with package dependencies if used : this prevents the compiler from using other includes that may be available on you're OS but aren't the same version (This easily happens with boost)

[Updated on: Sat, 19 September 2020 13:23]

Report message to a moderator

Send a private message to this user

[Message index]

		SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Xemuth on Tue, 15 September 2020 15:46
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: koldo on Tue, 15 September 2020 17:07
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Xemuth on Fri, 18 September 2020 23:15
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Didier on Fri, 18 September 2020 09:55
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: koldo on Fri, 18 September 2020 18:52
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Didier on Sat, 19 September 2020 12:46
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Xemuth on Fri, 18 September 2020 23:10
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: koldo on Fri, 18 September 2020 19:12
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Xemuth on Fri, 18 September 2020 22:57
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Klugier on Fri, 18 September 2020 23:17
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Xemuth on Sat, 19 September 2020 03:37
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Klugier on Sun, 20 September 2020 00:11
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Xemuth on Sun, 20 September 2020 16:45
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: Klugier on Thu, 24 September 2020 23:09
		Re: SurfaceCtrl, 3D viewer of Multiple file format and Surface class By: mirek on Wed, 17 February 2021 17:57

Previous Topic:	How to move packages from bazaar to github repo and UppHub
Next Topic:	Non core packages shouldn't be under ultimatepp umbrella organization on GitHub

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

PDF

]

Current Time: Sat Jul 05 19:59:59 CEST 2025

Total time taken to generate the page: 0.03503 seconds