U++ forum: Welcome to the forum

Re: wierd segmentation fault when execute theide [message #9594 is a reply to message #8141]

Fri, 18 May 2007 16:11

tomek
Messages: 1
Registered: May 2007

Junior Member

Hi,

I have very simlar error on my gentoo. I made some debug and here is result:

file: upp-2007.1/uppsrc/Draw/DrawTextXft.cpp
funciton:

static bool sCheckComposed(const char *face)

XftFontOpen() sometimes cannot open font, (in my case it is "ProFont" font) then it returns NULL. There is no checking so invalid pointer is used in XftCharExists() function.

Im not sure about logic of this function, but it should look like this to avoid segmentation fault:

static bool sCheckComposed(const char *face)
{
        XftFont *xftfont = XftFontOpen(Xdisplay, Xscreenno,
                                       XFT_FAMILY, XftTypeString, (char *)face,
                                       XFT_PIXEL_SIZE, XftTypeInteger, 20,
                                       (void *)0);
/// ---------
        if( xftfont == NULL )
                return false;
/// ---------
        int n = 0;
        for(int c = 0; c < 128; c++)
                if(!XftCharExists(Xdisplay, xftfont, c + 256))
                        n++;

        XftFontClose(Xdisplay, xftfont);
        return n > 10;
}

Probably font which cannot be opened should not be either collected by Draw::InitPlatformFonts() function.

Could someone fix it and provide new ebuild ?

When upp will be available in "standard" gentoo-portage tree?

Thanks,
Tom

Report message to a moderator