U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » U++ TheIDE » U++ TheIDE: CodeEditor, Assist++, Topic++ » A small issue with CodeEditor

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

A small issue with CodeEditor [message #46056]

Thu, 25 February 2016 13:55

cbpporter
Messages: 1427
Registered: September 2007

Ultimate Contributor

Just adding a CodeEditor to a window and setting line numbers and edit marks to true makes the edit mark be displayed over the line numbers.

This happens in all samples, except TheIDE, which somehow fixes this. I was not yet able to track down the issue but I'm investigating it.

I attached a simple test case. Just type something in the editor and the blue mark will be placed upon the "1" in line 1.

Attachment: testce.zip
(Size: 1.42KB, Downloaded 280 times)

Report message to a moderator

Re: A small issue with CodeEditor [message #46062 is a reply to message #46056]

Fri, 26 February 2016 14:06

cbpporter
Messages: 1427
Registered: September 2007

Ultimate Contributor

OK, this is very weird. Te out of the box EditorBar positioning is not the way it appears in TheIDE and based on the code I don't know how it could.

But here is what I found to work really good:

if(line_numbers && i < editor->GetLineCount()) {
			String n = AsString((i + 1) % 1000000);
			Font fnt = editor->GetFont();
			Size tsz = GetTextSize(n, fnt);
			w.DrawText(sz.cx + 1 + CodeEditorImg::Breakpoint().GetWidth() - Zx(4 + 12) - tsz.cx - annotations, y + (fy - tsz.cy) / 2, n, fnt, Brown);
		}

The DrawText line is the only one I changed.

I still have this weird empty line at the end of the CodeEditor, like in the attached image.

Attachment: ce.png
(Size: 56.82KB, Downloaded 702 times)

Report message to a moderator

Re: A small issue with CodeEditor [message #46063 is a reply to message #46062]

Fri, 26 February 2016 14:53

cbpporter
Messages: 1427
Registered: September 2007

Ultimate Contributor

Also, could we get this added to TabBar?

void AddFrameToScroolBar(CtrlFrame& fr) 				{ sc.AddFrame(fr); }

I need to add frames to that little scrollbar.

Report message to a moderator

Re: A small issue with CodeEditor [message #46065 is a reply to message #46063]

Fri, 26 February 2016 21:49

Klugier
Messages: 1099
Registered: September 2012
Location: Poland, Kraków

Senior Contributor

Hello cppborder,

I think we also put breakpoint in the wrong place. Please notice that it overlaps age information. In addition client programmer should have ability to turn off annotations and breakpoints.

For the firs issue I posted diff that adds age_width parameter to EditorBar and use it in draw method and size synchronization.

EDIT: DIFF deleted due to destroying annotations.

Sincerely,
Klugier

U++ - one framework to rule them all.

[Updated on: Sat, 27 February 2016 14:16]

Report message to a moderator

Re: A small issue with CodeEditor [message #46066 is a reply to message #46065]

Sat, 27 February 2016 03:01

cbpporter
Messages: 1427
Registered: September 2007

Ultimate Contributor

Hi Klugier,

I noticed that too, but I think it is perfectly fine for breakpoints to overlap the age block. Breakpoints are transitory and usually don't hang around a lot, that's why I didn't feel like having them overlay is a problem.

Aren't annotations off until you add them?

Right now I'm working on a mini code outline, like in Sublime text on the right in the image: http://www.tecmint.com/wp-content/uploads/2013/09/Sublime-Te xt-3.png

Report message to a moderator

Re: A small issue with CodeEditor [message #46067 is a reply to message #46066]

Sat, 27 February 2016 20:53

Klugier
Messages: 1099
Registered: September 2012
Location: Poland, Kraków

Senior Contributor

Hello cbpporter,

OK. Breakpoint can stay as it is, but we should have option to disable it. I think for app that only allows editing code this function is not necessary. So we should introduce function like "DebugerInterface(bool b);". What do you think?

Quote:

Aren't annotations off until you add them?

Right, annotations size is set by default to zero (look at EditorBar constructor). If you want to enable it you will probably need to use following method of EditorBar (CodeEditor/EditorBar.cpp):

void EditorBar::Annotations(int width)
{
	annotations = width;
	SyncSize();
}

Quote:

Right now I'm working on a mini code outline, like in Sublime text on the right in the image: http://www.tecmint.com/wp-content/uploads/2013/09/Sublime-Te xt-3.png

I wish we have separate code editor app outside TheIDE - maybe "U++ Edit" Smile

. Please notice that U++ code editor is super fast. In my opinion it works better than other tools like notepad++.

Sincerely,
Klugier

U++ - one framework to rule them all.

[Updated on: Sat, 27 February 2016 20:54]

Report message to a moderator

Re: A small issue with CodeEditor [message #46090 is a reply to message #46067]

Thu, 03 March 2016 10:43

cbpporter
Messages: 1427
Registered: September 2007

Ultimate Contributor

I did some progress with the preview but won't have time to finish it this release, so I'll hit it up again for next release.

As for breakpoints, if CodeEditor is wished to have the breakpoints optional, I can update the bar drawing to take this into account and post the code.

Report message to a moderator