U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » U++ Library support » U++ Core » Core/Ol_Set.cpp should to change!

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Core/Ol_Set.cpp should to change! [message #19003]

Tue, 04 November 2008 16:02

tojocky
Messages: 607
Registered: April 2008
Location: UK

Contributor

Hello!
I think that file Core/Ol_Set.cpp wich contain:

//#BLITZ_PROHIBIT

#ifndef flagNONAMESPACE
namespace Upp {
#endif

void Set__(volatile bool& b)
{
	//WriteMemoryBarrier should be here
	b = true;
}

#ifndef flagNONAMESPACE
};
#endif

will be great to change in this:

//#BLITZ_PROHIBIT

NAMESPACE_UPP

void Set__(volatile bool& b)
{
	//WriteMemoryBarrier should be here
	b = true;
}

END_UPP_NAMESPACE

Now, the functionality is identical, but in future when will need to add changes, will be great to change only Core.Core.h!

Report message to a moderator

Re: Core/Ol_Set.cpp should to change! [message #19005 is a reply to message #19003]

Tue, 04 November 2008 21:26

mirek
Messages: 13975
Registered: November 2005

Ultimate Member

Well, the only problem is that UPP_NAMESPACE is undefined there Smile

Anyway, I think that we will soon drop those UPP_NAMESPACE macros - they were introduced as prudent path in case previous 'non-namespace' mode of U++ would be required by any of existing apps - that never happened.

In fact, the only thing that stops me doing it is the size of svn commit after the change Smile

Mirek

Report message to a moderator

Previous Topic:	Report serialization
Next Topic:	(Possible) Serialization issue

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Apr 28 12:23:11 CEST 2024

Total time taken to generate the page: 0.04393 seconds