U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » Developing U++ » U++ TheIDE and Library: Releases and ChangeLogs » Quiz: What is wrong with this code?

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Quiz: What is wrong with this code? [message #3951]

Mon, 10 July 2006 23:16

mirek
Messages: 13975
Registered: November 2005

Ultimate Member

struct Rect_ {
.....
	Pt     CenterPoint() const              { return Pt((left + right) / 2, (top + bottom) / 2); }
.....
};

...should compute the central point of Rect...

(...fixed).

Mirek

Report message to a moderator

Re: Quiz: What is wrong with this code? [message #3953 is a reply to message #3951]

Tue, 11 July 2006 09:15

unodgs
Messages: 1366
Registered: November 2005
Location: Poland

Ultimate Contributor

luzr wrote on Mon, 10 July 2006 17:16

struct Rect_ {
.....
	Pt     CenterPoint() const              { return Pt((left + right) / 2, (top + bottom) / 2); }
.....
};

...should compute the central point of Rect...

(...fixed).

Mirek

Interesting.. looks fine to me..

Normaly computation of center point looks like:

top + (bottom - top) / 2

but it evaluates to:

top + bottom / 2 - top / 2 =
top / 2 + bottom /2 =
(top + bottom) / 2

Is that bug related to const modifier??

Report message to a moderator

Re: Quiz: What is wrong with this code? [message #3958 is a reply to message #3953]

Tue, 11 July 2006 17:25

mirek
Messages: 13975
Registered: November 2005

Ultimate Member

unodgs wrote on Tue, 11 July 2006 03:15

luzr wrote on Mon, 10 July 2006 17:16

struct Rect_ {
.....
	Pt     CenterPoint() const              { return Pt((left + right) / 2, (top + bottom) / 2); }
.....
};

...should compute the central point of Rect...

(...fixed).

Mirek

No. The problem is when top and bottom are ints and top + bottom is negative - "evaluates" is no longer true....

Mirek

[Updated on: Tue, 11 July 2006 17:26]

Report message to a moderator

Re: Quiz: What is wrong with this code? [message #3971 is a reply to message #3958]

Tue, 11 July 2006 23:36

unodgs
Messages: 1366
Registered: November 2005
Location: Poland

Ultimate Contributor

luzr wrote on Tue, 11 July 2006 11:25

No. The problem is when top and bottom are ints and top + bottom is negative - "evaluates" is no longer true....

Yes, negatives... they didn't come into my mind Smile

Report message to a moderator

Re: Quiz: What is wrong with this code? [message #10479 is a reply to message #3971]

Wed, 11 July 2007 14:12

pap2k
Messages: 8
Registered: June 2007

Promising Member

Is it fix ?

the folowing sample produce wrong result on my fresh version :
Pointf center =
Rectf( Pointf(-1.0,82), Pointf(7,-92)).CenterPoint();

Report message to a moderator

Re: Quiz: What is wrong with this code? [message #10480 is a reply to message #10479]

Wed, 11 July 2007 14:22

pap2k
Messages: 8
Registered: June 2007

Promising Member

I'm stupid man ...
result produce is good ... that's my in mind calculation wich was false.

I'm sory to disturb you.

Report message to a moderator

Previous Topic:	Some macro enhancements for TheIde
Next Topic:	Fixed QuickTabs DnD refreshing problems. Mouse wheel works in tiny bar too now..,

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Apr 30 21:33:21 CEST 2024

Total time taken to generate the page: 0.03272 seconds