Hi

Please correct this issue https:// www.ultimatepp.org/forums/index.php?t=msg&th=12005&s tart=0& in the new release.

Best regards,
Victor

Hi Mirek,

There is an issue with FileSel with the current version. I can select a file, e.g. "datafile.csv", but the returned result is "datafile.csv.csv". Sometimes FileSel compalains it cannot find the file that was picked up from the list:

	FileSel fs;
	fs.Multi();
	fs.Type(t_("All supported formats"),"*.csv; *.CSV; *.txt; *.TXT");
	fs.Type(t_("Comma separated values file"),"*.csv; *.CSV");
	fs.Type(t_("Text file"),"*.txt; *.TXT");
	
	if(fs.ExecuteOpen(t_("Import data file"))){

Best regards,

Tom

		fs.Type(t_("All supported formats"),"*.csv *.CSV *.txt *.TXT");
		fs.Type(t_("Comma separated values file"),"*.csv *.CSV");
		fs.Type(t_("Text file"),"*.txt; *.TXT");

Hi,

Would it be possible to add Null support for float?

I think below you can find pretty much what is needed in Core/Defs.h:

...
constexpr double DOUBLE_NULL    =    -std::numeric_limits<double>::infinity();
constexpr float FLOAT_NULL    =    -std::numeric_limits<float>::infinity();

class Nuller {
public:
	operator int() const                { return INT_NULL; }
	operator int64() const              { return INT64_NULL; }
	operator double() const             { return DOUBLE_NULL; }
	operator float() const              { return FLOAT_NULL; }
	operator bool() const               { return false; }

	Nuller() {}
};

extern const Nuller Null;

template <class T> void SetNull(T& x) { x = Null; }

template <class T> bool IsNull(const T& x)       { return x.IsNullInstance(); }

template<> inline bool  IsNull(const int& i)     { return i == INT_NULL; }
template<> inline bool  IsNull(const int64& i)   { return i == INT64_NULL; }
template<> inline bool  IsNull(const double& r)  { return !(std::abs(r) < std::numeric_limits<double>::infinity()); }
template<> inline bool  IsNull(const float& r)   { return !(std::abs(r) < std::numeric_limits<float>::infinity()); }
template<> inline bool  IsNull(const bool& r  )  { return false; }
...

Best regards,

Tom

Tom1 wrote on Fri, 12 May 2023 10:23

Hi Mirek,

There is an issue with FileSel with the current version. I can select a file, e.g. "datafile.csv", but the returned result is "datafile.csv.csv". Sometimes FileSel compalains it cannot find the file that was picked up from the list:

	FileSel fs;
	fs.Multi();
	fs.Type(t_("All supported formats"),"*.csv; *.CSV; *.txt; *.TXT");
	fs.Type(t_("Comma separated values file"),"*.csv; *.CSV");
	fs.Type(t_("Text file"),"*.txt; *.TXT");
	
	if(fs.ExecuteOpen(t_("Import data file"))){

Best regards,

Tom

Remove ';'.

		fs.Type(t_("All supported formats"),"*.csv *.CSV *.txt *.TXT");
		fs.Type(t_("Comma separated values file"),"*.csv *.CSV");
		fs.Type(t_("Text file"),"*.txt; *.TXT");

Tom1 wrote on Fri, 12 May 2023 15:09

Hi,

Would it be possible to add Null support for float?

I think below you can find pretty much what is needed in Core/Defs.h:

...
constexpr double DOUBLE_NULL    =    -std::numeric_limits<double>::infinity();
constexpr float FLOAT_NULL    =    -std::numeric_limits<float>::infinity();

class Nuller {
public:
	operator int() const                { return INT_NULL; }
	operator int64() const              { return INT64_NULL; }
	operator double() const             { return DOUBLE_NULL; }
	operator float() const              { return FLOAT_NULL; }
	operator bool() const               { return false; }

	Nuller() {}
};

extern const Nuller Null;

template <class T> void SetNull(T& x) { x = Null; }

template <class T> bool IsNull(const T& x)       { return x.IsNullInstance(); }

template<> inline bool  IsNull(const int& i)     { return i == INT_NULL; }
template<> inline bool  IsNull(const int64& i)   { return i == INT64_NULL; }
template<> inline bool  IsNull(const double& r)  { return !(std::abs(r) < std::numeric_limits<double>::infinity()); }
template<> inline bool  IsNull(const float& r)   { return !(std::abs(r) < std::numeric_limits<float>::infinity()); }
template<> inline bool  IsNull(const bool& r  )  { return false; }
...

Best regards,

Tom

Too big change in time of release, even if I thought this is a good idea (I am yet undecided). Let us discuss float at the start of the next cycle, ok?