Overview
Examples
Screenshots
Comparisons
Applications
Download
Documentation
Tutorials
Bazaar
Status & Roadmap
FAQ
Authors & License
Forums
Funding Ultimate++
Search on this site
Search in forums












SourceForge.net Logo
Home » Community » U++ community news and announcements » 2023.1rc1
2023.1rc1 [message #59871] Sun, 14 May 2023 11:03 Go to next message
mirek is currently offline  mirek
Messages: 13996
Registered: November 2005
Ultimate Member
- MacOS is supported again; POSIX and MACOS releases are now merged to single archive
- clang-format integration
- .iml image selection database tool
- many fixes....
icon14.gif  Re: 2023.1rc1 [message #59872 is a reply to message #59871] Sun, 14 May 2023 21:40 Go to previous messageGo to next message
GiuMar is currently offline  GiuMar
Messages: 4
Registered: August 2022
Location: Italy
Junior Member
Thank you very much. Smile
Re: 2023.1rc1 [message #59875 is a reply to message #59871] Mon, 15 May 2023 15:10 Go to previous messageGo to next message
Tom1
Messages: 1221
Registered: March 2007
Senior Contributor
Thanks Mirek!

I will keep testing.

Best regards,

Tom
Re: 2023.1rc1 [message #59890 is a reply to message #59875] Sun, 21 May 2023 10:53 Go to previous messageGo to next message
Klugier is currently offline  Klugier
Messages: 1077
Registered: September 2012
Location: Poland, Kraków
Senior Contributor
Hello Mirek,

I found two issues

1) the first one is related to next/back stack for TheIDE build in help. It means that when you click on some entry for example "Assist++" you can not back to initial help menu. There are also problems with table of contents, it doesn't work in that view.

Also, when you open help for the first time after launching TheIDE it has back entry. It shouldn't be there and the stack should be empty.

Please test you, I believe you should find all mentioned issues pretty quickly.

2) The light breeze-gtk theme on Manjaro for menu bar is broken. It means that top menu bar works correctly, but nested are not. I attached screenshot to show this issue. Left is upp, right is LibreOffice that handles it correctly.
index.php?t=getfile&id=6805&private=0
In above text the menu item text should be black not white. Also, the new/updated styling algorith should do not break topiteam text. This might requires bigger reworked.

Klugier


U++ - one framework to rule them all.

[Updated on: Sun, 21 May 2023 10:55]

Report message to a moderator

Re: 2023.1rc1 [message #59891 is a reply to message #59890] Sun, 21 May 2023 11:01 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13996
Registered: November 2005
Ultimate Member
Klugier wrote on Sun, 21 May 2023 10:53
Hello Mirek,

2) The light breeze-gtk theme on Manjaro for menu bar is broken. It means that top menu bar works correctly, but nested are not. I attached screenshot to show this issue. Left is upp, right is LibreOffice that handles it correctly.
index.php?t=getfile&id=6805&private=0
In above text the menu item text should be black not white. Also, the new/updated styling algorith should do not break topiteam text. This might requires bigger reworked.

Klugier


CtrlLib/ChGtk3.cpp:507

There is now 100. Increasing the value should fix the problem.

It would be also interesting to DDUMP(Diff(c, s.menutext)), DDUMP(c), DDUMP(s.menutext) so that we know what we are dealing with...
Re: 2023.1rc1 [message #59892 is a reply to message #59891] Sun, 21 May 2023 11:32 Go to previous messageGo to next message
Klugier is currently offline  Klugier
Messages: 1077
Registered: September 2012
Location: Poland, Kraków
Senior Contributor
Hello Mirek,

I dumped these values as you suggested:
Begin
Before if
Diff(c, s.menutext) = 14
c = Color(241, 242, 243)
s.menutext = Color(255, 255, 255)
After if
Diff(c, s.menutext) = 243
c = Color(241, 242, 243)
s.menutext = Color(0, 0, 0)
End

Also, I increased if value even to 200, 250 without any effect. I think the issue here is more complicated that simple changing the shift value. There is a difference between menubar and single menus. The menubar is rendered correctly, but the menu is not. We might need to support this additional state.

Klugier


U++ - one framework to rule them all.

[Updated on: Sun, 21 May 2023 11:35]

Report message to a moderator

Re: 2023.1rc1 [message #59893 is a reply to message #59892] Sun, 21 May 2023 13:34 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13996
Registered: November 2005
Ultimate Member
I have tried to refactor the code a bit, can you test with master? Ideally, with multiple themes.
Re: 2023.1rc1 [message #59894 is a reply to message #59893] Sun, 21 May 2023 13:53 Go to previous messageGo to next message
Klugier is currently offline  Klugier
Messages: 1077
Registered: September 2012
Location: Poland, Kraków
Senior Contributor
Hello Mirek,

The issue has been fixed for Breeze Light and Dark. Thank you for that! You also forget to remove debug code in production (line 513 - ChGtk4.cpp):
PNGEncoder().SaveFile("/home/cxl/item.png", item);


For other themes, I noticed that there is a issue for Adwaita (KDE Gtk Theme). The bar text should be white instead of black. I attached U++ (left) comparison with Chrom (right).
index.php?t=getfile&id=6806&private=0

Klugier
  • Attachment: Adwaita.png
    (Size: 47.21KB, Downloaded 257 times)


U++ - one framework to rule them all.
Re: 2023.1rc1 [message #59895 is a reply to message #59890] Sun, 21 May 2023 14:38 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13996
Registered: November 2005
Ultimate Member
Klugier wrote on Sun, 21 May 2023 10:53
Hello Mirek,

I found two issues

1) the first one is related to next/back stack for TheIDE build in help. It means that when you click on some entry for example "Assist++" you can not back to initial help menu. There are also problems with table of contents, it doesn't work in that view.

Also, when you open help for the first time after launching TheIDE it has back entry. It shouldn't be there and the stack should be empty.

Please test you, I believe you should find all mentioned issues pretty quickly.


Hopefully fixed, can you test?
Re: 2023.1rc1 [message #59896 is a reply to message #59894] Sun, 21 May 2023 14:45 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13996
Registered: November 2005
Ultimate Member
Klugier wrote on Sun, 21 May 2023 13:53
Hello Mirek,

The issue has been fixed for Breeze Light and Dark. Thank you for that! You also forget to remove debug code in production (line 513 - ChGtk4.cpp):
PNGEncoder().SaveFile("/home/cxl/item.png", item);


For other themes, I noticed that there is a issue for Adwaita (KDE Gtk Theme). The bar text should be white instead of black. I attached U++ (left) comparison with Chrom (right).
index.php?t=getfile&id=6806&private=0

Klugier

Thanks, can you put some DDUMPs there?

DDUMP(c);
DDUMP(s.itemtext);
DDUMP(Diff(c, s.itemtext));

Alternatively, we can try to improve Diff:

int Diff(RGBA a, RGBA b)
{
	return max(abs(a.a - b.a), max(abs(a.r - b.r) / 2, max(abs(a.b - b.b) / 5, abs(a.g - b.g))));
}


(This accounts for even maxed blue color being dark)

Mirek
Re: 2023.1rc1 [message #59897 is a reply to message #59896] Sun, 21 May 2023 18:58 Go to previous messageGo to next message
Klugier is currently offline  Klugier
Messages: 1077
Registered: September 2012
Location: Poland, Kraków
Senior Contributor
Hello Mirek,

Alternative diff method doesn't help in this case. For the log in ChGtk3.cpp file:
"Start" = Start
"Before if" = Before if
c = Color(241, 246, 253)
s.itemtext = Color(255, 255, 255)
Diff(c, s.itemtext) = 9
"After if" = After if
c = Color(241, 246, 253)
s.itemtext = Color(0, 0, 0)
Diff(c, s.itemtext) = 246
"End" = End


Klugier


U++ - one framework to rule them all.
Re: 2023.1rc1 [message #59898 is a reply to message #59897] Sun, 21 May 2023 20:07 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13996
Registered: November 2005
Ultimate Member
Klugier wrote on Sun, 21 May 2023 18:58
Hello Mirek,

Alternative diff method doesn't help in this case. For the log in ChGtk3.cpp file:
"Start" = Start
"Before if" = Before if
c = Color(241, 246, 253)
s.itemtext = Color(255, 255, 255)
Diff(c, s.itemtext) = 9
"After if" = After if
c = Color(241, 246, 253)
s.itemtext = Color(0, 0, 0)
Diff(c, s.itemtext) = 246
"End" = End


Klugier


I think I found it, can you recheck the master?
Re: 2023.1rc1 [message #59899 is a reply to message #59871] Sun, 21 May 2023 20:32 Go to previous messageGo to next message
Oblivion is currently offline  Oblivion
Messages: 1097
Registered: August 2007
Senior Contributor
Hi Mirek,

There is also a small problem with configurable keys.

CtrlLib/AKeys.cpp:255

	if(p.IsNumber()) {
		uint32 q = p.ReadNumber(16); // <- The number key combinations (e.g. CTRL+SHIFT+1) can't be used, apparently due to the number base (16).
		if(q <= 9)
			return f | (K_0 + q);
		return f | q;
	}



Edit:

This is what I get in reference/AK (log)

s = - "Setup";
ENGLISH                   Ctrl+1;
CZECH                     Ctrl+3;
KEYS                      Ctrl+4;

- "AK";
FN1                       Ctrl+ń;
FN2                       Ctrl+W;
EXIT                      Ctrl+D;


p.PeekChar() = 1
q = 20
p.PeekChar() = 4
q = 68



Best regards,
Oblivion


[Updated on: Sun, 21 May 2023 20:44]

Report message to a moderator

Re: 2023.1rc1 [message #59900 is a reply to message #59898] Sun, 21 May 2023 20:53 Go to previous messageGo to next message
Klugier is currently offline  Klugier
Messages: 1077
Registered: September 2012
Location: Poland, Kraków
Senior Contributor
Hello Mirek,

After your last commit everything works as expected. I also tested other themes for regression, but they behave as expected. Thank you! Now, TheIDE help stabilization is waiting Smile

Klugier


U++ - one framework to rule them all.

[Updated on: Sun, 21 May 2023 20:54]

Report message to a moderator

Re: 2023.1rc1 [message #59901 is a reply to message #59871] Sun, 21 May 2023 21:17 Go to previous messageGo to next message
Oblivion is currently offline  Oblivion
Messages: 1097
Registered: August 2007
Senior Contributor
Another test code for failing configurable key parser:

	String s1 = "1;\n";
	String s2 = "1;";
	String s3 = "1";

	uint32 i = CParser(s1).ReadNumber(16);
	RLOG("1) Base 16: " << i);
	uint32 j = CParser(s1).ReadNumber(10);
	RLOG("1) Base 10: " << j);
	
	RLOG("-----");
	
	uint32 k = CParser(s2).ReadNumber(16);
	RLOG("2) Base 16: " << k);
	uint32 l = CParser(s2).ReadNumber(10);
	RLOG("2) Base 10: " << l);

	RLOG("-----");

	uint32 m = CParser(s3).ReadNumber(16);
	RLOG("3) Base 16: " << m);
	uint32 n = CParser(s3).ReadNumber(10);
	RLOG("3) Base 10: " << n);
	



Results:

1) Base 16: 20
1) Base 10: 1
-----
2) Base 16: 20
2) Base 10: 1
-----
3) Base 16: 1
3) Base 10: 1




Seems that CParser.GetNumber(16) is not reading the number correctly.

Best regards,
Oblivion



[Updated on: Sun, 21 May 2023 21:23]

Report message to a moderator

Re: 2023.1rc1 [message #59902 is a reply to message #59901] Mon, 22 May 2023 09:41 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13996
Registered: November 2005
Ultimate Member
Oblivion wrote on Sun, 21 May 2023 21:17
Another test code for failing configurable key parser:

	String s1 = "1;\n";
	String s2 = "1;";
	String s3 = "1";

	uint32 i = CParser(s1).ReadNumber(16);
	RLOG("1) Base 16: " << i);
	uint32 j = CParser(s1).ReadNumber(10);
	RLOG("1) Base 10: " << j);
	
	RLOG("-----");
	
	uint32 k = CParser(s2).ReadNumber(16);
	RLOG("2) Base 16: " << k);
	uint32 l = CParser(s2).ReadNumber(10);
	RLOG("2) Base 10: " << l);

	RLOG("-----");

	uint32 m = CParser(s3).ReadNumber(16);
	RLOG("3) Base 16: " << m);
	uint32 n = CParser(s3).ReadNumber(10);
	RLOG("3) Base 10: " << n);
	



Results:

1) Base 16: 20
1) Base 10: 1
-----
2) Base 16: 20
2) Base 10: 1
-----
3) Base 16: 1
3) Base 10: 1




Seems that CParser.GetNumber(16) is not reading the number correctly.

Best regards,
Oblivion



CParser.GetNumber(16) hopefully fixed in master...
Re: 2023.1rc1 [message #59903 is a reply to message #59900] Mon, 22 May 2023 09:42 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13996
Registered: November 2005
Ultimate Member
Klugier wrote on Sun, 21 May 2023 20:53
Hello Mirek,

After your last commit everything works as expected. I also tested other themes for regression, but they behave as expected. Thank you! Now, TheIDE help stabilization is waiting Smile

Klugier


I have commited the fix yesterday, perhaps you missed it, or is is still in need of "stabilisation"?
Re: 2023.1rc1 [message #59904 is a reply to message #59903] Mon, 22 May 2023 14:32 Go to previous messageGo to next message
Klugier is currently offline  Klugier
Messages: 1077
Registered: September 2012
Location: Poland, Kraków
Senior Contributor
mirek wrote on Mon, 22 May 2023 09:42
Klugier wrote on Sun, 21 May 2023 20:53
Hello Mirek,

After your last commit everything works as expected. I also tested other themes for regression, but they behave as expected. Thank you! Now, TheIDE help stabilization is waiting Smile

Klugier


I have commited the fix yesterday, perhaps you missed it, or is is still in need of "stabilisation"?


Hello Mirek,

Everything works fine. I wrote my message after using your last commit from yesterday. We can assume for now that GTK menubar styling works as expected.

Klugier


U++ - one framework to rule them all.
Re: 2023.1rc1 [message #59905 is a reply to message #59904] Mon, 22 May 2023 15:20 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13996
Registered: November 2005
Ultimate Member
Klugier wrote on Mon, 22 May 2023 14:32
mirek wrote on Mon, 22 May 2023 09:42
Klugier wrote on Sun, 21 May 2023 20:53
Hello Mirek,

After your last commit everything works as expected. I also tested other themes for regression, but they behave as expected. Thank you! Now, TheIDE help stabilization is waiting Smile

Klugier


I have commited the fix yesterday, perhaps you missed it, or is is still in need of "stabilisation"?


Hello Mirek,

Everything works fine. I wrote my message after using your last commit from yesterday. We can assume for now that GTK menubar styling works as expected.

Klugier


That is one confusing reply... Smile

(The question was about help fw/bk)

Mirek
Re: 2023.1rc1 [message #59906 is a reply to message #59902] Mon, 22 May 2023 19:20 Go to previous messageGo to previous message
Oblivion is currently offline  Oblivion
Messages: 1097
Registered: August 2007
Senior Contributor
Hello Mirek,

Thank you, the problem with ordinary number keys is fixed.
However, I have also noticed that while registering NUMPAD keys in the keys dialog is possible, the apps can neither store nor restore them.

E.g. "Num0" to "Num9" are represented in the dialog, and can be used, but they can't be re/stored.

Is it possible to fix (or implement) them too?

Best regards,
Oblivion


[Updated on: Mon, 22 May 2023 19:42]

Report message to a moderator

Previous Topic: 2023.1 alpha
Next Topic: 2023.1rc3
Goto Forum:
  


Current Time: Wed Jul 24 08:47:04 CEST 2024

Total time taken to generate the page: 0.02162 seconds