However, e.g. RectTracker does not work as is with my Wacom tablet. The specific pen support (I just posted) is simply required for it to work. (I'm now under impression that RectTracker works with your tablet perfectly without these changes... ?? Perhaps XP-PEN drivers can avoids Windows Ink and work more mouse-like through the stack.)

Tom1 wrote on Fri, 26 March 2021 18:52

However, e.g. RectTracker does not work as is with my Wacom tablet. The specific pen support (I just posted) is simply required for it to work. (I'm now under impression that RectTracker works with your tablet perfectly without these changes... ?? Perhaps XP-PEN drivers can avoids Windows Ink and work more mouse-like through the stack.)

Sorry, I might get lost in the code that we exchange here a lot...

Do you mean that my variant where Pen returns false and RectTracker is called in normal LeftDown does not work with Wacom? (My impression so far was that you are only testing RectTracker in Pen virtual method).

If so, does it mean RectTracker does not work even in pre-Pen U++? (With Wacom in "mouse mode")

Mirek

bool Pen(Point p, const PenInfo& pn, dword keyflags) override {
		if(keyflags & K_SHIFT)
			return false;
		if(pn.pressure) {
			if((!!pn.pressure == !!pen.pressure) && drawing.GetCount())
				drawing.Top().Add(MakeTuple(pn.pressure, p));
			else
				drawing.Add().Add(MakeTuple(pn.pressure, p));
		}
		pen = pn;
		Refresh();
		return true;
	}
	
	void LeftDown(Point p, dword keyflags) override {
		if(keyflags & K_SHIFT) {
			RectTracker tracker(*this);
			tracker.MinSize(Size(-100000,-100000));
			tracker.Track(Rect(p,p));
		}
	}

mirek wrote on Sat, 27 March 2021 10:11

Tom1 wrote on Fri, 26 March 2021 18:52

However, e.g. RectTracker does not work as is with my Wacom tablet. The specific pen support (I just posted) is simply required for it to work. (I'm now under impression that RectTracker works with your tablet perfectly without these changes... ?? Perhaps XP-PEN drivers can avoids Windows Ink and work more mouse-like through the stack.)

Sorry, I might get lost in the code that we exchange here a lot...

Do you mean that my variant where Pen returns false and RectTracker is called in normal LeftDown does not work with Wacom? (My impression so far was that you are only testing RectTracker in Pen virtual method).

If so, does it mean RectTracker does not work even in pre-Pen U++? (With Wacom in "mouse mode")

Mirek

Hi,

With original pre-Pen U++, RectTracker worked with Wacom at correct coordinates. (It only suffered from the Windows Ink induced 2 cm starting delay, but the rectangle followed pen thereafter.)

With current trunk code and testing with:

bool Pen(Point p, const PenInfo& pn, dword keyflags) override {
		if(keyflags & K_SHIFT)
			return false;
		if(pn.pressure) {
			if((!!pn.pressure == !!pen.pressure) && drawing.GetCount())
				drawing.Top().Add(MakeTuple(pn.pressure, p));
			else
				drawing.Add().Add(MakeTuple(pn.pressure, p));
		}
		pen = pn;
		Refresh();
		return true;
	}
	
	void LeftDown(Point p, dword keyflags) override {
		if(keyflags & K_SHIFT) {
			RectTracker tracker(*this);
			tracker.MinSize(Size(-100000,-100000));
			tracker.Track(Rect(p,p));
		}
	}

the tracking rect still of course has the 2 cm starting delay. However, now the rect dragged corner lags behind with a 2 cm constant dx,dy offset. Please see below a photo of a live 'while dragging' situation. So, actually, RectTracker is now worse than before introducing pen support:


Further on, what I really need with RectTracker, is that there is no 2 cm reaction delay. The tracking must start immediately from PEN_DOWN event. My RectTracker inherited sketching code requires immediate reaction for even a single pixel pen drags. This is why I need specific Pen() support in RectTracker.

Best regards,

Tom

Yes. Widgets mostly work. Some flickering with e.g. Menu, but I think nothing is severely broken. I can do a more thorough check later.

Breaking out from WM_POINTER* instead of return 0L; does not have any effect on this test with RectTracker. Offset remains.

The core problem in my opinion is ::GetCursorPos which does not work with pen. This comes evident with drags.

OK. In the new commit I treat GetCursorPos as "not reliable", overriding it with position got from lParam.

Only dragging a top menu item to open a drop down menu causes flickering of the selected item on the drop down menu. If the drop down menu is opened by a pen click, hovering on top of the sub menu works correctly without any flickering.

Mirek,

I did a video clip portraying the menu highlight flickering issue. Sent a PM on that.

There is no such anomaly on pre-pen U++.

Best regards,

Tom

Well, that means that in the movie, you have used pen to open the menu, right?

Does this disbehave with mouse too? (Without animation?)

What happens if you comment out CtrlCore/Win32Proc.cpp:74?

Mirek

//	POINT p;
//	if(::GetCursorPos(&p))
		//CurrentMousePos = p;

mirek wrote on Mon, 29 March 2021 16:35

Well, that means that in the movie, you have used pen to open the menu, right?

Does this disbehave with mouse too? (Without animation?)

What happens if you comment out CtrlCore/Win32Proc.cpp:74?

Mirek

1. Yes, I used pen throughout the video.

2. With mouse it works perfectly OK. There is no click animation with mouse.

3. Commenting out:

//	POINT p;
//	if(::GetCursorPos(&p))
		//CurrentMousePos = p;

Does not change anything.

Best regards,

Tom

Logging the changes shows that it's HasFocus() and especially HasMouse() that oscillates:

[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+     0 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+    32 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+     0 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+    31 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+     0 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+    31 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+     0 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+    31 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+     0 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+    32 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+     0 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+    31 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+     0 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+    31 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+     0 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true
[+     0 ms] HasMouse() = true
[+    31 ms] HasFocus() = false
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasMouse() = true
[+     0 ms] HasMouse() = false
[+     0 ms] HasFocus() = true

Best regards,

Tom

Do you have Windows Ink enabled with your XP-PEN? If not, please do. You might then see the click animations and experience the drag lag. Maybe the menu issue shows itself then...(?)

BR,

Tom