Overview
Examples
Screenshots
Comparisons
Applications
Download
Documentation
Tutorials
Bazaar
Status & Roadmap
FAQ
Authors & License
Forums
Funding Ultimate++
Search on this site
Search in forums












SourceForge.net Logo
Home » U++ Library support » U++ Library : Other (not classified elsewhere) » bug in DbfView example
bug in DbfView example [message #10778] Sat, 28 July 2007 15:06 Go to next message
mr_ped is currently offline  mr_ped
Messages: 825
Registered: November 2005
Location: Czech Republic - Praha
Experienced Contributor
 
GUI_APP_MAIN
{
    SetDefaultCharset(CHARSET_WIN1250);
    SetLanguage(LNG_CZECH);
    Ctrl::NoLayoutZoom();
...


The SetLanguage does call (if the language is really changed):
SetDefaultCharset(GetLNGCharset(lang));
so the SetDefaultCharset after GUI_APP_MAIN is useless and misleading anyone who wants to learn UPP from examples. Smile

Report message to a moderator

Re: bug in DbfView example [message #10801 is a reply to message #10778] Mon, 30 July 2007 05:23 Go to previous messageGo to next message
mr_ped is currently offline  mr_ped
Messages: 825
Registered: November 2005
Location: Czech Republic - Praha
Experienced Contributor
I found out some more problems...

1)
	while(dbf.Fetch()) {
		Vector<Value> v;
		for(int i = 0; i < min(4, dbf.GetFieldCount()); i++)
			v.Add(dbf[i]);
		table.Add(v);
	}


Does add all record to table, but it does skip over deleted rows, what does cause inconsistency with later

void DbfView::EnterRow()
{
	row.Clear();
	if(!dbf.Fetch(table.GetCursor()))
		return;


So you get wrong detailed view in such case, and whole index will be moved by -1 to -n (number of deleted rows).

Quick fix:
	if(!dbf.Open(~fs))
		Exclamation("Can't open input file");
	for(int i = 0; i < min(4, dbf.GetFieldCount()); i++)
		table.AddColumn(FormatField(dbf.GetField(i)));
	for (int ri = 0; ri < dbf.GetRowCount(); ++ri ) {
		Vector<Value> v;
		if(!dbf.Fetch(ri)) v.Add("DELETED");
		else for(int i = 0; i < min(4, dbf.GetFieldCount()); i++) v.Add(dbf[i]);
		table.Add(v);
	}


edit: ARGH, I used the local "i" two times... not very good programming practice... Very Happy ... so I changed it to "ri".

This will add also deleted rows to the main table, so the cursor is always right than.




2)
I'm unable to show correct czech characters no matter what charset I try. (in my desperation I tried all 26 of them)
My code to convert looks like this (in void DbfView::EnterRow):
...
	for(int i = 0; i < dbf.GetFieldCount(); i++) {
		Value val = dbf[i];
		if ( val.GetType() == STRING_V ) {
			String valtxt = val.ToString();
			//WString valwtxt = ToUnicode(valtxt, CHARSET_WIN1250);
			WString valwtxt = ToUnicode(valtxt, dbf.GetCharset() );
			row.Add(FormatField(dbf.GetField(i)), valwtxt);
		} else {
			row.Add(FormatField(dbf.GetField(i)), val);
		}


U++ 2007.1, Kubuntu 6.10
Charset for IDE: UTF-8
Charset for application: tried UTF-8, win1250, ISO8859_2, CP852, MJK

No luck so far... I will try it later on windows, maybe there some charset will work??

@Mirek: is it possible the result on windows will be different?

(P.S. I'm trying to do my first commercial project in U++, something very small, ugly, and it should work with DBF files from FoxPro ... the final application will be for Windows, but so far I'm developing just some base and toying around, so I'm staying in my main system so far ... that's the reason why I'm so into this example, I really must be sure I understand the DBF plugin enough Smile )

[Updated on: Mon, 30 July 2007 05:25]

Report message to a moderator

Re: bug in DbfView example [message #10802 is a reply to message #10778] Mon, 30 July 2007 06:04 Go to previous messageGo to next message
mr_ped is currently offline  mr_ped
Messages: 825
Registered: November 2005
Location: Czech Republic - Praha
Experienced Contributor
Just another one:

    fs.AllFilesType();
    fs.Type("*.dbf", "dbf");
    if(!fs.ExecuteOpen("DBF..")) return;


The filter *.dbf does not work in Linux.
Fix (to add asterisk and dot ahead of second dbf):
    ...
    fs.Type("*.dbf", "*.dbf");
    ...


I'm not sure if this works for windows and which one is the "correct" way to use in U++. Was it just a problem with example and my fix is correct, or the whole filter thing is broken in Linux and U++ FileSel requires fixing?

Report message to a moderator

Re: bug in DbfView example [message #10804 is a reply to message #10802] Mon, 30 July 2007 12:05 Go to previous messageGo to next message
mrjt is currently offline  mrjt
Messages: 705
Registered: March 2007
Location: London
Contributor
"name", "filter" is the correct format. For example:
fs.Type("Text Files", "*.txt");

Although ".txt" will also work.

Report message to a moderator

Re: bug in DbfView example [message #11076 is a reply to message #10804] Sat, 18 August 2007 11:05 Go to previous message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
mrjt wrote on Mon, 30 July 2007 06:05

"name", "filter" is the correct format. For example:
fs.Type("Text Files", "*.txt");

Although ".txt" will also work.




Sorry about messed example...

This should solve some of problems, please test:

#include <CtrlLib/CtrlLib.h>
#include <plugin/dbf/dbf.h>

using namespace Upp;

struct DbfView : public TopWindow {
	Splitter s;
	ArrayCtrl table;
	ArrayCtrl row;
	DbfStream dbf;

	void EnterRow();
	void Perform();

	typedef DbfView CLASSNAME;

	DbfView();
};

String FormatField(const DbfStream::Field& f)
{
	return f.name + Format(" (%c%d)", f.type, f.width);
}

void DbfView::EnterRow()
{
	row.Clear();
	if(!dbf.Fetch(table.GetKey()))
		return;
	for(int i = 0; i < dbf.GetFieldCount(); i++)
		row.Add(FormatField(dbf.GetField(i)), dbf[i]);
}

void DbfView::Perform()
{
	FileSel fs;
	LoadFromFile(fs);
	fs.AllFilesType();
	fs.Type("dbf", "*.dbf");
	if(!fs.ExecuteOpen("DBF..")) return;
	StoreToFile(fs);
	if(!dbf.Open(~fs))
		Exclamation("Can't open input file");
	table.AddKey();
	for(int i = 0; i < min(4, dbf.GetFieldCount()); i++)
		table.AddColumn(FormatField(dbf.GetField(i)));
	while(dbf.Fetch()) {
		Vector<Value> v;
		v.Add(dbf.GetPos());
		for(int i = 0; i < min(4, dbf.GetFieldCount()); i++)
			v.Add(dbf[i]);
		table.Add(v);
	}
	Run();
}

DbfView::DbfView()
{
	s.Set(table, row);
	s.SetPos(7000);
	Add(s.SizePos());
	Sizeable().Zoomable();
	table.WhenEnterRow = THISBACK(EnterRow);
	row.AddColumn("Column");
	row.AddColumn("Value", 2);
}

GUI_APP_MAIN
{
	SetDefaultCharset(CHARSET_WIN1252);
	Ctrl::NoLayoutZoom();

	DbfView().Perform();
}


I am moving this to the "library" area...



Mirek

Report message to a moderator

Previous Topic: bug? : operator "!" for "bool"
Next Topic: howto access SVN please?
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Fri Apr 19 13:35:56 CEST 2024

Total time taken to generate the page: 0.02151 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.5.
Copyright ©2001-2013 FUDforum Bulletin Board Software