Overview
Examples
Screenshots
Comparisons
Applications
Download
Documentation
Tutorials
Bazaar
Status & Roadmap
FAQ
Authors & License
Forums
Funding Ultimate++
Search on this site
Search in forums












SourceForge.net Logo
Home » Developing U++ » U++ Developers corner » Include option for specific package
Re: Include option for specific package [message #22202 is a reply to message #22191] Wed, 24 June 2009 10:09 Go to previous messageGo to next message
mr_ped is currently offline  mr_ped
Messages: 825
Registered: November 2005
Location: Czech Republic - Praha
Experienced Contributor
luzr wrote on Tue, 23 June 2009 17:09

Well, I am sorry to be stubborn, I am just STRONGLY opposed to the idea that package should have any explicit include paths.

Mirek


+1
That would make packages hard to relocate easily, like now.
Re: Include option for specific package [message #22203 is a reply to message #22202] Wed, 24 June 2009 10:59 Go to previous messageGo to next message
koldo is currently offline  koldo
Messages: 3357
Registered: August 2008
Senior Veteran
Hello mr_ped

Nobody in this thread wants absolute paths Smile

mr_ped wrote on Wed, 24 June 2009 10:09

luzr wrote on Tue, 23 June 2009 17:09

Well, I am sorry to be stubborn, I am just STRONGLY opposed to the idea that package should have any explicit include paths.

Mirek


+1
That would make packages hard to relocate easily, like now.


We only want paths relative to package folder and under it.

For example, this diagram:

index.php?t=getfile&id=1814&private=0

Why this. For making wrappers to other libraries.

Situations:

1. Library directory structure is very simple: Nothing to do
2. Library directory structure is not very simple. Solutions:
2.1 Change library source code. In my opinion this is ugly
2.2 Put the library tree under Upp package and compile it seting include path structure under Upp package. This is something we like.

Best regards
Koldo
  • Attachment: Lay.PNG
    (Size: 9.66KB, Downloaded 587 times)


Best regards
IƱaki
Re: Include option for specific package [message #22208 is a reply to message #22203] Wed, 24 June 2009 13:28 Go to previous messageGo to next message
tojocky is currently offline  tojocky
Messages: 607
Registered: April 2008
Location: UK
Contributor

I agree with Koldo!
Maybe I proposed not finished variant. but we can restrict for do not permit to set absolute paths
koldo wrote on Wed, 24 June 2009 11:59

Hello mr_ped

Nobody in this thread wants absolute paths Smile

mr_ped wrote on Wed, 24 June 2009 10:09

luzr wrote on Tue, 23 June 2009 17:09

Well, I am sorry to be stubborn, I am just STRONGLY opposed to the idea that package should have any explicit include paths.

Mirek


+1
That would make packages hard to relocate easily, like now.


We only want paths relative to package folder and under it.

For example, this diagram:

index.php?t=getfile&id=1814&private=0

Why this. For making wrappers to other libraries.

Situations:

1. Library directory structure is very simple: Nothing to do
2. Library directory structure is not very simple. Solutions:
2.1 Change library source code. In my opinion this is ugly
2.2 Put the library tree under Upp package and compile it seting include path structure under Upp package. This is something we like.

Best regards
Koldo

Re: Include option for specific package [message #22216 is a reply to message #22208] Wed, 24 June 2009 19:38 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
Well, OK, sorry for the resistance.

I have tried, my proposal, although solving the problem, is rejected.

I will add tojocky's method ASAP.

The only thing to consider is some better name that would indicate that the whole issue is really only useful for incorporating 3rd party libraries....

Mirek
Re: Include option for specific package [message #22221 is a reply to message #22216] Thu, 25 June 2009 13:20 Go to previous messageGo to next message
tojocky is currently offline  tojocky
Messages: 607
Registered: April 2008
Location: UK
Contributor

Thank you Mirek, Sorry us for the resistance too!
If you have not time for this, I can propose the final variant to restrict access for any path, and integrate FileSel to select folder.

With respect, Ion Lupascu (tojocky)

luzr wrote on Wed, 24 June 2009 20:38

Well, OK, sorry for the resistance.

I have tried, my proposal, although solving the problem, is rejected.

I will add tojocky's method ASAP.

The only thing to consider is some better name that would indicate that the whole issue is really only useful for incorporating 3rd party libraries....

Mirek


Re: Include option for specific package [message #22266 is a reply to message #22221] Sun, 28 June 2009 21:53 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
Done.
Re: Include option for specific package [message #22276 is a reply to message #22266] Mon, 29 June 2009 14:49 Go to previous messageGo to next message
tojocky is currently offline  tojocky
Messages: 607
Registered: April 2008
Location: UK
Contributor

luzr wrote on Sun, 28 June 2009 22:53

Done.


Hello Mirek,
Nice realization, but..... my realization it adds internal include package for current build package and for uses packages. In your realization add internal include package only fro current build package.

I want to discuss about this, how is correct. Your realization is good when I do a package which wrap a library.

In my case (XLSLIB) it is not work because I use direct link to library from other package!

OK, Question:

Is correct to add include package for uses packages too?

My opinion: it is necessary to add (by priority) inlcude internal package for uses packages.

[Updated on: Mon, 29 June 2009 15:06]

Report message to a moderator

Re: Include option for specific package [message #22278 is a reply to message #22276] Mon, 29 June 2009 19:41 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
You are right...

Mirek
Re: Include option for specific package [message #22279 is a reply to message #22278] Mon, 29 June 2009 19:56 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
Changed: All packages now using internal include paths.

Mirek
Re: Include option for specific package [message #22285 is a reply to message #22279] Tue, 30 June 2009 16:42 Go to previous messageGo to next message
tojocky is currently offline  tojocky
Messages: 607
Registered: April 2008
Location: UK
Contributor

luzr wrote on Mon, 29 June 2009 20:56

Changed: All packages now using internal include paths.

Mirek


Hello Mirek!

It is better, but analyzing package structure, for example:
index.php?t=getfile&id=1820&private=0

If only XLS Lib package have internal include then on building need add only for: XLS_LIB and Current_Package.
For other packages as CtrlLib, CtrlCore, and other is not need to add!
  • Attachment: upp_tree.PNG
    (Size: 17.26KB, Downloaded 455 times)
Re: Include option for specific package [message #22286 is a reply to message #22285] Tue, 30 June 2009 17:17 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
tojocky wrote on Tue, 30 June 2009 10:42

luzr wrote on Mon, 29 June 2009 20:56

Changed: All packages now using internal include paths.

Mirek


Hello Mirek!

It is better, but analyzing package structure, for example:
index.php?t=getfile&id=1820&private=0

If only XLS Lib package have internal include then on building need add only for: XLS_LIB and Current_Package.
For other packages as CtrlLib, CtrlCore, and other is not need to add!



Can it do any real harm?

The only thing comes to mind is the same name of header.

Mirek
Re: Include option for specific package [message #22287 is a reply to message #22286] Tue, 30 June 2009 17:19 Go to previous message
tojocky is currently offline  tojocky
Messages: 607
Registered: April 2008
Location: UK
Contributor

luzr wrote on Tue, 30 June 2009 18:17



Can it do any real harm?

The only thing comes to mind is the same name of header.

Mirek


Yes, I thing too! May have situation when is same name of header!
Previous Topic: Abstract Draw
Next Topic: CeGCC
Goto Forum:
  


Current Time: Sat Apr 27 10:50:51 CEST 2024

Total time taken to generate the page: 0.03307 seconds