U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » U++ Library support » U++ Core » A few bugs in Core/Rpc

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

A few bugs in Core/Rpc [message #39351]

Wed, 13 March 2013 13:43

steffen
Messages: 38
Registered: May 2007
Location: Denmark

Member

Hi,
We are trying to use the JsonRPCRequest and have stumbled over a few bugs (svn rev. 5909):

Two warnings on missing return value in Core/Rpc/legacy.h:

inline
bool   XmlRpcPerform(TcpSocket& http, const char *group)
{
	RpcPerform(http, group);
}

inline
bool   XmlRpcServerLoop(int port, const char *group = NULL)
{
	RpcServerLoop(port, group);
}

Should be changed to

inline
bool   XmlRpcPerform(TcpSocket& http, const char *group)
{
	return RpcPerform(http, group);
}

inline
bool   XmlRpcServerLoop(int port, const char *group = NULL)
{
	return RpcServerLoop(port, group);
}

Also our server expects to see Content-Type="application/json", which I think is correct for http transport.
We tried to call OurJsonRpcRequest.ContentType("application/json"), but was not allowed because RpcRequest inherits privately from HttpRequest. We would also like to change the timeouts and call the Abort function, so please make it public inheritance.

In Core/Rpc/Rpc.h: