U++ forum: Welcome to the forum

Application hangs on renaming directories accidentally [message #52359]

Sat, 14 September 2019 03:18

zsolt
Messages: 696
Registered: December 2005
Location: Budapest, Hungary

Contributor

Some users try changing to a directory with double click, but too slowly, so FileSel changes the directory name editable.
But the user don't want to rename it, so presses Enter key.
This hangs the app for seconds on the top of a large directory tree. Just try it with Windows directory.

Proposed patch is very simple:

 void FileSel::Rename(const String& on, const String& nn) {
+	if(on == nn) return;
 #ifdef PLATFORM_WIN32
 	if(FileMove(FilePath(on), FilePath(nn)))

[Updated on: Mon, 14 October 2019 18:14]

Report message to a moderator