U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » Community » U++ community news and announcements » get_i

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: get_i [message #54274 is a reply to message #54273]

Wed, 17 June 2020 23:21

Novo
Messages: 1358
Registered: December 2006

Ultimate Contributor

mirek wrote on Wed, 17 June 2020 15:03

Thanks. Trunk version are a bit different now, can you review?

In your last commit you've added std::forward not to all places.
I've attached my version.
I also changed a functor signature in "void iter_get(I s, Args& ...args)".
Just a reference is fine there ...
IMHO, functors and iterators should be passed by reference to avoid extra-copying ...

Attachment: Fn.h
(Size: 3.28KB, Downloaded 153 times)

Regards,
Novo

Report message to a moderator

[Message index]

		get_i By: mirek on Sun, 14 June 2020 19:10
		Re: get_i By: Novo on Tue, 16 June 2020 17:45
		Re: get_i By: mirek on Tue, 16 June 2020 17:52
		Re: get_i By: Novo on Tue, 16 June 2020 18:02
		Re: get_i By: Novo on Tue, 16 June 2020 18:21
		Re: get_i By: mirek on Tue, 16 June 2020 21:20
		Re: get_i By: Novo on Tue, 16 June 2020 22:15
		Re: get_i By: mirek on Wed, 17 June 2020 00:01
		Re: get_i By: Novo on Wed, 17 June 2020 07:01
		Re: get_i By: Novo on Wed, 17 June 2020 07:09
		Re: get_i By: Novo on Wed, 17 June 2020 07:23
		Re: get_i By: Novo on Wed, 17 June 2020 07:50
		Re: get_i By: mirek on Wed, 17 June 2020 09:35
		Re: get_i By: mirek on Wed, 17 June 2020 13:03
		Re: get_i By: Novo on Wed, 17 June 2020 19:00
		Re: get_i By: Novo on Wed, 17 June 2020 19:14
		Re: get_i By: mirek on Wed, 17 June 2020 21:03
		Re: get_i By: Novo on Wed, 17 June 2020 23:21
		Re: get_i By: Novo on Wed, 17 June 2020 23:59
		Re: get_i By: mirek on Thu, 18 June 2020 08:39
		Re: get_i By: Novo on Thu, 18 June 2020 23:56
		Re: get_i By: Novo on Tue, 16 June 2020 21:22
		Re: get_i By: mirek on Tue, 16 June 2020 21:25
		Re: get_i By: Novo on Tue, 16 June 2020 21:42
		Re: get_i By: Novo on Wed, 17 June 2020 06:39
		Re: get_i By: mirek on Mon, 29 June 2020 19:23
		Re: get_i By: Novo on Thu, 02 July 2020 22:08
		Re: get_i By: mirek on Fri, 03 July 2020 09:38
		Re: get_i By: Novo on Fri, 03 July 2020 18:53
		Re: get_i By: mirek on Fri, 03 July 2020 19:03

Previous Topic:	ide: Assist parsing now parallel and some of it background
Next Topic:	2020.1 officially released

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon May 20 05:29:12 CEST 2024

Total time taken to generate the page: 0.01107 seconds