U++ forum: Welcome to the forum

Status & Roadmap

Authors & License

Funding Ultimate++

Search on this site

Search in forums

Home » Community » U++ community news and announcements » Upp 610-dev2 released

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Return to the default flat view

Create a new topic

Submit Reply

Re: Upp 610-dev2 released [message #5810 is a reply to message #5802]

Tue, 17 October 2006 18:50

guido is currently offline

guido
Messages: 169
Registered: April 2006

Experienced Member

Thanks!
Went into the debugger with it and found the culprit.
In TopWinX11.cpp -> TopWindow:Open() there is a safe-guard missing, when retreiving the frame extents:

Vector<int> fe = GetPropertyInts(top->window, XAtom("_NET_FRAME_EXTENTS"));
	if (fe != NULL)
	{
		windowFrameMargin.left = max(windowFrameMargin.left, fe[0]);
		windowFrameMargin.right = max(windowFrameMargin.right, fe[1]);
		windowFrameMargin.top = max(windowFrameMargin.top, fe[2]);
		windowFrameMargin.bottom = max(windowFrameMargin.bottom, fe[3]);
	}

My window-manager didn't support this hint. So without the pointer safe-guard, like you see I added above, it'll crash.
I made the window-manager support the hint meanwhile. Still, that's reckless programming style Evil or Very Mad

Evil or Very Mad

Guido

Report message to a moderator

Send a private message to this user

[Message index]

		Upp 610-dev2 released By: unodgs on Sun, 15 October 2006 23:51
		Re: Upp 610-dev2 released By: guido on Mon, 16 October 2006 20:13
		Re: Upp 610-dev2 released By: unodgs on Mon, 16 October 2006 22:54
		Re: Upp 610-dev2 released By: guido on Tue, 17 October 2006 18:50
		Re: Upp 610-dev2 released By: mirek on Wed, 18 October 2006 01:13
		Re: Upp 610-dev2 released By: guido on Wed, 18 October 2006 01:51
		Re: Upp 610-dev2 released By: guido on Wed, 18 October 2006 03:11
		Re: Upp 610-dev2 released By: mirek on Fri, 20 October 2006 15:27
		Re: Upp 610-dev2 released By: guido on Fri, 20 October 2006 16:41
		Re: Upp 610-dev2 released By: mirek on Fri, 20 October 2006 17:43
		Re: Upp 610-dev2 released By: guido on Fri, 20 October 2006 22:52
		Re: Upp 610-dev2 released By: mirek on Sat, 21 October 2006 03:20
		Re: Upp 610-dev2 released By: fallingdutch on Sat, 21 October 2006 10:50
		Re: Upp 610-dev2 released By: mirek on Sat, 21 October 2006 14:46

Previous Topic:	Quick start issues for new users
Next Topic:	Upp 610-dev3 released

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

PDF

]

Current Time: Sat Apr 27 05:38:40 CEST 2024

Total time taken to generate the page: 0.04709 seconds