U++ forum: Welcome to the forum

Re: Prefix to prevent name clash in SQL: SqlId, variables, tables, ... [message #14201 is a reply to message #14170]

Tue, 19 February 2008 23:42

mirek
Messages: 13979
Registered: November 2005

Ultimate Member

OK, why not. Path accepted.

Only I have rather placed ToUpper to Execute -> that way we will avoid ToUpper in each row fetch... (Equality comparison is fast, ToUpper is not...):

bool Sql::Execute() {
	SqlSession &session = GetSession();
	if(session.traceslow < INT_MAX)
		cn->starttime = GetTickCount();
	if(session.usrlog)
		UsrLogT(9, cn->statement);
	Stream *s = session.GetTrace();
	if(s) {
#ifndef NOAPPSQL
		if(this == &AppCursor())
			*s << "SQL* ";
#endif
		*s << cn->statement << '\n';
	}
	session.GetStatus().Statement(cn->statement);
	session.PassStatus(ActivityStatus::EXECUTING);
	bool b = cn->Execute();
	session.GetStatus().Time(GetTickCount() - cn->starttime);
	session.PassStatus(ActivityStatus::END_EXECUTING);
	if(!b) {
		if(s) {
			*s << "## ERROR: " << session.GetLastError() << '\n';
		}
		session.GetStatus()
			.Error(session.GetLastError())
			.ErrorCode(session.GetErrorCode())
			.ErrorCode(session.GetErrorCodeString());
		session.PassStatus(ActivityStatus::EXECUTING_ERROR);
	}
	for(int i = 0; i < cn->info.GetCount(); i++)
		cn->info[i].name = ToUpper(cn->info[i].name);
	return b;
}

(please check)

BTW, was your suggestion based on real problems or do you just want to play safe?

Mirek

Report message to a moderator