U++ forum: Welcome to the forum

Re: FileSel and international files problem when getting icon image [message #18753 is a reply to message #18542]

Sun, 19 October 2008 22:48

mirek
Messages: 13975
Registered: November 2005

Ultimate Member

koldo wrote on Tue, 07 October 2008 07:17

Hello all

I have found a problem when reading international file names. In these cases the icon is not readed.

Searching around I have found that the struct FileIconMaker has a member declared String file. If the file name has non english characters the function virtual Image Make() does not work.

To solve it I simply change this in FileSel.cpp:

for(int i = 0; i < 2; i++) {
     SHFILEINFO info;
     SHGetFileInfo(file, dir ? FILE_ATTRIBUTE_DIRECTORY : FILE_ATTRIBUTE_NORMAL, &info, sizeof(info),

with this;

WString wfile = file.ToWString();
for(int i = 0; i < 2; i++) {
     SHFILEINFOW info;
     SHGetFileInfo(wfile, dir ? FILE_ATTRIBUTE_DIRECTORY : FILE_ATTRIBUTE_NORMAL, &info, sizeof(info),

and it works.

Best regards
Koldo

Well, first I have applied this patch, but I am afraid this would not work with Win98.

Could you try this first?

		for(int i = 0; i < 2; i++) {
			SHFILEINFO info;
			SHGetFileInfo(ToSystemCharset(file), dir ? FILE_ATTRIBUTE_DIRECTORY : FILE_ATTRIBUTE_NORMAL,
			              &info, sizeof(info),
			              SHGFI_ICON|SHGFI_SMALLICON|(exe ? 0 : SHGFI_USEFILEATTRIBUTES));

Mirek

[Updated on: Sun, 19 October 2008 22:50]

Report message to a moderator