U++ forum: Welcome to the forum

FIX: proper use of Style in Ctrls from CtrlLib [message #27072]

Thu, 24 June 2010 12:38

kohait00
Messages: 939
Registered: July 2009
Location: Germany

Experienced Contributor

hi folks,

i stumbled over inconsistant use of style stuff inside some upp Ctrls, names EditCtrl, Calender, Clock, ButtonOption..

they should not have stuff like

Paint:
const Style &st = style ? *style : StyleDefault();

but should instead properly do what other Ctrl's do

ctor:
style = &StyleDefault();

//Paint and elsewhere
style->line...

this prevents things from breaking up when editing global style information (over StyleDefault)..

i attached a rar file with .svn inside to easy compare what i mean.

PS: neither should Font be part of Style or should it.. i havent found any other that Calender Ctrl to be the case... because SetFont should be used instead, right?

RFC

Attachment: CtrlLib.rar
(Size: 975.03KB, Downloaded 335 times)

Report message to a moderator