U++ forum: Welcome to the forum

Search on this site

Search in forums

Fri, 04 February 2011 14:55

mirek
Messages: 13975
Registered: November 2005

Ultimate Member

chickenk wrote on Fri, 04 February 2011 04:43

Another question: can someone explain the line below (CtrlLib/DocEdit.cpp line 325) and try to make it less ambiguous with parentheses ?

if(q >= 0 && q != cursor && delta < 0 == q < cursor && GetCaret(q).y != yy) {...}

We'll see if some opinions diverge about what this code generates... I suppose this is the following :

if(
      (q >= 0) &&
      (q != cursor) &&
      ( (delta < 0) == (q < cursor) ) &&
      (GetCaret(q).y != yy)
   ) {...}

Yes. I have remade it to

		if(q >= 0 && q != cursor && (delta < 0) == (q < cursor) && GetCaret(q).y != yy) {

Mirek

		Various fixes to uppsrc By: chickenk on Thu, 03 February 2011 13:27
		Re: Various fixes to uppsrc By: chickenk on Fri, 04 February 2011 10:43
		Re: Various fixes to uppsrc By: mirek on Fri, 04 February 2011 14:55
		Re: Various fixes to uppsrc By: mirek on Fri, 04 February 2011 15:07
		Re: Various fixes to uppsrc By: chickenk on Fri, 04 February 2011 15:43
		Re: Various fixes to uppsrc By: mirek on Fri, 04 February 2011 15:51
		Re: Various fixes to uppsrc By: chickenk on Fri, 04 February 2011 15:53
		Re: Various fixes to uppsrc By: mirek on Fri, 04 February 2011 15:49
		Re: Various fixes to uppsrc By: chickenk on Fri, 04 February 2011 15:50
		Re: Various fixes to uppsrc By: mirek on Fri, 04 February 2011 16:06

Previous Topic:	GCC warnings patch - mega mix 1 - unused variables and contructor var init order (SVN r2960)
Next Topic:	Issues with new stable release 3211

Goto Forum:

] [

]

Current Time: Sat May 04 10:20:50 CEST 2024

Total time taken to generate the page: 0.01865 seconds