U++ forum: Welcome to the forum

Re: Various fixes to uppsrc [message #31094 is a reply to message #31064]

Fri, 04 February 2011 15:07

mirek
Messages: 13975
Registered: November 2005

Ultimate Member

chickenk wrote on Thu, 03 February 2011 07:27

[*] CtrlLib/Splitter.cpp : move some initialisations from the ctor body to its initialization list, and set chstyle to NULL initially

Is this supposed to fix anything? (except maybe chstyle).

Quote:

[*] Core/Defs.h : make the BREAK address volatile to avoid optimizations

[*] art/BlueBar/BlueBar.upp : depends on CtrlLib

OK, applied.

Quote:

[*] plugin/png/... : make the path to the headers uniform, also avoids confusion with the system png headers

Wrong. If you would want to put the longer path there, you should have '<' instead of '"'.

Quote:

[*] Painter/Painter.upp : Should depend directly on the same basis of system libs as CtrlCore. I believe this one should be reviewed seriously, I'm not sure about the exact needs.[/list]

That would be a dire mistake. We want Painter to work even without X11.

However, I guess it SHOULD add fontconfig and freetype.

Mirek

[Updated on: Fri, 04 February 2011 15:11]

Report message to a moderator