U++ forum: Welcome to the forum

Re: Various fixes to uppsrc [message #31096 is a reply to message #31094]

Fri, 04 February 2011 15:43

chickenk
Messages: 169
Registered: May 2007
Location: Grenoble, France

Experienced Member

mirek wrote on Fri, 04 February 2011 15:07

chickenk wrote on Thu, 03 February 2011 07:27

[*] CtrlLib/Splitter.cpp : move some initialisations from the ctor body to its initialization list, and set chstyle to NULL initially

Is this supposed to fix anything? (except maybe chstyle).

Indeed, does not fix anything apart from chstyle.

Quote:

[*] plugin/png/... : make the path to the headers uniform, also avoids confusion with the system png headers

Wrong. If you would want to put the longer path there, you should have '<' instead of '"'.

So in that case I believe we should have <plugin/png/png.h>. Do you agree?

Quote:

[*] Painter/Painter.upp : Should depend directly on the same basis of system libs as CtrlCore. I believe this one should be reviewed seriously, I'm not sure about the exact needs.[/list]

That would be a dire mistake. We want Painter to work even without X11.

However, I guess it SHOULD add fontconfig and freetype.

Mirek

Ouch, you're right. I can't remember exactly but I suppose I added these for fontconfig and freetype, but I added the X11 bits by mistake as well.

Thanks for looking at these Smile

Lionel

Report message to a moderator