U++ forum: Welcome to the forum

[bug report] EditField::StdBar Undo menu not checked and EditField::RightDown is reentrant [message #37276]

Fri, 14 September 2012 08:56

jinshiyi11
Messages: 7
Registered: October 2010
Location: CHINA

Promising Member

1.I think Undo menu should be disabled when EditField is readonly.

menu.Add(t_("Undo"), THISBACK(Undo))
		.Key(K_ALT_BACKSPACE)
		.Key(K_CTRL_Z);

So I change it to

menu.Add(IsEditable(),t_("Undo"), THISBACK(Undo))
		.Key(K_ALT_BACKSPACE)
		.Key(K_CTRL_Z);

2.When I repeat right click EditField,the EditField::RightDown method is reentrant.The stack likes the following:
index.php?t=getfile&id=3872&private=0

When I close the parent window,it may crash at the next code line.(It's easy to reproduce it in my project)

In the Upp's help document,"About modal loops and periodic timer events" has talked about this.I think EditField::RightDown should be protected.

Attachment: reentrant.png
(Size: 27.29KB, Downloaded 455 times)

[Updated on: Fri, 14 September 2012 08:57]

Report message to a moderator