Home » U++ Library support » U++ Core » PipeStream - bidirectional Stream
| Re: PipeStream - bidirectional Stream [message #39141 is a reply to message #38945] |
Mon, 18 February 2013 19:48   |
 |
mirek
Messages: 13976
Registered: November 2005
|
Ultimate Member |
|
|
After some more detailed code-review, there is one thing that makes me uneasy, and it is rdlim/wrlim.
First, you are comparing real pointers to NULL there, which is undefined in C/C++. Well, it will work in practice, but still...
More serious (but related) is the fact, that you are not using them at all  Which in turn means that all the logic behind "fast" inlined Get/Put goes away. Perhaps I am not seeing everything right, but I think that you should be able to setup correct rdlim/wrlim in SetStatus and Get/Put... (if there is a reason, please tell, I am inclined to try myself, so if it is no-go, I would save my time 
Somewhat related (in LZMA). In LzmaInStream::Read, how do you know that there is size elements available in PipeStream? I guess there is a reason hidden in the code, but I decided to ask first
Mirek
|
|
|
|
Current Time: Sun May 12 11:08:07 CEST 2024
Total time taken to generate the page: 0.02630 seconds
|
Members
Pages
Help
Register
Login
Home
