U++ forum: Welcome to the forum

Rare bug on CtrlCore/ImageWin32.cpp [message #46058]

Fri, 26 February 2016 04:39

rxantos
Messages: 72
Registered: October 2011

Member

On function

void ImageSysData::Paint(SystemDraw& w, int x, int y, const Rect& src, Color c);

Search for

if(!himg) {
  LTIMING("Image Alpha create");
  BitmapInfo32__ bi(sz.cx, sz.cy);
  himg = CreateDIBSection(ScreenHDC(), bi, DIB_RGB_COLORS, (void **)&section, NULL, 0);
  Copy(section, ~img, img.GetLength());
}

Sometimes CreateDIBSection fails. Is rare, but it does happen returning 0 in the process, which causes the Copy function to crash the application.
Propose to change with.

if(!himg) {
  LTIMING("Image Alpha create");
  BitmapInfo32__ bi(sz.cx, sz.cy);
  himg = CreateDIBSection(ScreenHDC(), bi, DIB_RGB_COLORS, (void **)&section, NULL, 0);
  ASSERT(himg); // Assert on debug
  if(!himg) {
   return; // Return on release.
  }
  Copy(section, ~img, img.GetLength());
}

Report message to a moderator