U++ forum: Welcome to the forum

Status & Roadmap

Authors & License

Funding Ultimate++

Search on this site

Search in forums

Home » Developing U++ » U++ Developers corner » [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ (Discussion about implementing a single threaded synchronization tool for handling non-blocking I/O.)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Return to the default flat view

Create a new topic

Submit Reply

Re: [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ [message #46076 is a reply to message #46074]

Mon, 29 February 2016 17:23

mirek is currently offline

mirek
Messages: 13980
Registered: November 2005

Ultimate Member

Just a small nitpicking for now...

		for(int i  = 0; i < test_stack.GetCount(); i++) {
.......
				test_stack.Remove(i);

this combo is generally incorrect - it skips the element after the removed one. It probably works OK here (the next element gets tested/removed in the pass), but still...

if(WhenDo) WhenDo()

No need for if, it is OK to call unassigned Callback - it is NOP.

    template<class T>T& GetJobArg(int i)                        { return job_queue[i].Get<T>(i); }

I smell the bug here - is 'i' index of VectorMap or index of VarArgs?

Overall, I am pretty unsure what is that VectorMap useful for. You are never using it as map,except for RemoveJob. Not that all those VectorMap::Insert/Remove operations are quite slow.

In practice, I am not quite sure you really need a queue there. Do we really need more than single level?

Also, we are going full C++11 soon. Lambdas would make superior alternative for both DoJob and VarArgs IMO.

Mirek

[Updated on: Mon, 29 February 2016 17:37]

Report message to a moderator

Send a private message to this user

[Message index]

		[PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ By: Oblivion on Sun, 28 February 2016 19:47
		Re: [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ By: Mindtraveller on Mon, 29 February 2016 16:36
		Re: [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ By: Oblivion on Mon, 29 February 2016 17:21
		Re: [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ By: mirek on Mon, 29 February 2016 17:23
		Re: [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ By: Oblivion on Mon, 29 February 2016 18:25
		Re: [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ By: mirek on Mon, 29 February 2016 18:34
		Re: [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ By: Oblivion on Wed, 02 March 2016 00:22
		Re: [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ By: mr_ped on Mon, 29 February 2016 21:55
		Re: [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ By: Oblivion on Mon, 29 February 2016 22:09
		Re: [PROPOSAL]: AsyncQueue class (a single threaded synchronization tool) for U++ By: Oblivion on Wed, 02 March 2016 20:15

Previous Topic:	[OpenGL][FreeBSD] GLDrawDemo Problem
Next Topic:	Problem update FreeBSD

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

PDF

]

Current Time: Tue May 14 01:32:57 CEST 2024

Total time taken to generate the page: 0.02616 seconds