Feature #1604

Streamlined and corrected CodeEditor bar size and positions

Added by cbpporter cbpporter almost 3 years ago. Updated almost 3 years ago.

Status:In ProgressStart date:01/04/2017
Priority:NormalDue date:
Assignee:cbpporter cbpporter% Done:

0%

Category:CodeEditorSpent time:-
Target version:-

Description

Just simply dropping a CodeEditor somewhere and setting up the correct properties can often lead to elements like change tracker, #if highlight, numbers, breakpoints, annotations to clip.

You either need to fiddle with them in counter intuitive ways or accept the clipping.

The fix makes everything add up in a simple fashion and there is no clipping.

Side effects: the bar can be a few pixels wider than the old one. Shouldn't be a problem with modern high width monitors. Maybe scaling needs to be added?

CodeEditor.h Magnifier (15.8 KB) cbpporter cbpporter, 01/04/2017 04:42 PM

EditorBar.cpp Magnifier (11.8 KB) cbpporter cbpporter, 01/04/2017 04:42 PM

History

#1 Updated by Miroslav Fidler almost 3 years ago

  • Status changed from New to In Progress
  • Assignee set to cbpporter cbpporter

I appears that proposed patch is using 'fixed' number of pixels in most places. Also it appears like it is derived from some pretty old U++ baseline sources.

The number of pixels should be adjusted with Zx/Zy (based on font zooming ratio) or with Dx/Dy (based on display being UHD).

Mirek

#2 Updated by cbpporter cbpporter almost 3 years ago

Miroslav Fidler wrote:

I appears that proposed patch is using 'fixed' number of pixels in most places. Also it appears like it is derived from some pretty old U++ baseline sources.

The number of pixels should be adjusted with Zx/Zy (based on font zooming ratio) or with Dx/Dy (based on display being UHD).

Mirek

Weird. I thought I merged with the latest release before posting. But I did not change the content of the new lines, which are indeed based on an old version of CodeEditor.

Also available in: Atom PDF