Bug #1716

CParser:: IsId(const char*) && Id(const char*) does not check for valid C id

Added by Abdelghani Omari over 5 years ago. Updated over 5 years ago.

Status:RejectedStart date:05/12/2017
Priority:NormalDue date:
Assignee:Miroslav Fidler% Done:

0%

Category:CoreSpent time:-
Target version:-

Description

for example:

CParser p("123");
p.Id("123"); return true instead of false, because "123" is not a valid C id.

Parser.patch Magnifier (1021 Bytes) Abdelghani Omari, 05/12/2017 08:49 PM

History

#1 Updated by Miroslav Fidler over 5 years ago

  • Status changed from Patch ready to Rejected

This is performance critical place and and the same time, it just does not make much sense to use it this way.

Maybe updating docs, but I really do not see why this is a problem.

#2 Updated by Abdelghani Omari over 5 years ago

OK.

i think we shall update the docs.

we can add a sentence like :

The caller is responsible for calling this function with a valid C-like identifier.

Also available in: Atom PDF