CParser:: IsId(const char*) && Id(const char*) does not check for valid C id
|Assignee:||Miroslav Fidler||% Done:|
p.Id("123"); return true instead of false, because "123" is not a valid C id.
#1 Updated by Miroslav Fidler almost 6 years ago
- Status changed from Patch ready to Rejected
This is performance critical place and and the same time, it just does not make much sense to use it this way.
Maybe updating docs, but I really do not see why this is a problem.
#2 Updated by Abdelghani Omari almost 6 years ago
i think we shall update the docs.
we can add a sentence like :
The caller is responsible for calling this function with a valid C-like identifier.