Bug #1716
CParser:: IsId(const char*) && Id(const char*) does not check for valid C id
| Status: | Rejected | Start date: | 05/12/2017 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | Miroslav Fidler | % Done: | 0% | |
| Category: | Core | Spent time: | - | |
| Target version: | - |
Description
for example:
CParser p("123");p.Id("123"); return true instead of false, because "123" is not a valid C id.Parser.patch 
(1021 Bytes)
History
#1 Updated by Miroslav Fidler over 7 years ago
- Status changed from Patch ready to Rejected
This is performance critical place and and the same time, it just does not make much sense to use it this way.
Maybe updating docs, but I really do not see why this is a problem.
#2 Updated by Abdelghani Omari over 7 years ago
OK.
i think we shall update the docs.
we can add a sentence like :
The caller is responsible for calling this function with a valid C-like identifier.