Task #1944

Fix compilation warnings on macOS with clang as a compiler

Added by Zbigniew Rebacz 5 months ago. Updated 2 months ago.

Status:Ready for QAStart date:03/18/2019
Priority:HighDue date:
Assignee:Miroslav Fidler% Done:

0%

Category:GeneralSpent time:-
Target version:Release 2019.2

Description

Below is the list of warnings generated while compiling TheIDE:

/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/IconDes/IconDes.h (135): warning: 'Upp::IconDes::MouseEnter' hides overloaded virtual function [-Woverloaded-virtual]
/Users/rebaczz/out/uppsrc/ide/IconDes/CLANG.Debug.Debug_Full.Gui.Shared/$blitz.cpp (3): In file included from /Users/rebaczz/out/uppsrc/ide/IconDes/CLANG.Debug.Debug_Full.Gui.Shared/$blitz.cpp:3:
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/ide/IconDes/IconDes.cpp (1): In file included from /Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/ide/IconDes/IconDes.cpp:1:
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/ide/IconDes/IconDes.h (5): In file included from /Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/ide/IconDes/IconDes.h:5:
 (): virtual void  MouseEnter()                             { SyncStatus(); }
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/CtrlCore.h (838): note: hidden overloaded virtual function 'Upp::Ctrl::MouseEnter' declared here: different number of parameters (2 vs 0)
 (): virtual void   MouseEnter(Point p, dword keyflags);
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/IconDes/IconDes.h (135): warning: 'Upp::IconDes::MouseEnter' hides overloaded virtual function [-Woverloaded-virtual]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlLib/FileSel.cpp (462): warning: unused variable 'isdrive' [-Wunused-variable]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlLib/FileSel.cpp (529): warning: unused variable 'isdrive' [-Wunused-variable]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlLib/ChCoco.cpp (97): warning: unused variable 'sz' [-Wunused-variable]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/IconDes/IconDes.h (135): warning: 'Upp::IconDes::MouseEnter' hides overloaded virtual function [-Woverloaded-virtual]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/IconDes/IconDes.h (135): warning: 'Upp::IconDes::MouseEnter' hides overloaded virtual function [-Woverloaded-virtual]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/Draw/Raster.h (37): warning: private field 'amask' is not used [-Wunused-private-field]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/CtrlCore/Coco.h (107): warning: 'BackDraw__' defined as a struct here but previously declared as a class [-Wmismatched-tags]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/IconDes/IconDes.h (135): warning: 'Upp::IconDes::MouseEnter' hides overloaded virtual function [-Woverloaded-virtual]
/Users/rebaczz/Applications/TheIDE.app/Contents/SharedSupport/uppsrc/ide/idewin.cpp (327): warning: unused variable 'l' [-Wunused-variable]

We should fix it before release. We definitely don't want to scary users with warning on the library level ;)

History

#1 Updated by Zbigniew Rebacz 5 months ago

  • Tracker changed from Bug to Task

#2 Updated by Miroslav Fidler 5 months ago

  • Status changed from New to Ready for QA

#3 Updated by Zbigniew Rebacz 5 months ago

  • Status changed from Ready for QA to In Progress

One more warning with Clang on GNU/Linux detected (with -Wall flag):

/home/klugier/upp/uppsrc/Draw/Cham.cpp (187): warning: explicitly assigning value of variable of type 'Upp::Image' to itself [-Wself-assign-overloaded]

#4 Updated by Miroslav Fidler 5 months ago

  • Status changed from In Progress to Ready for QA

#5 Updated by Zbigniew Rebacz 2 months ago

  • Target version changed from Release 2019.1 to Release 2019.2

Also available in: Atom PDF