Feature #2078
FileSelButton should display "Select path.." tip
| Status: | Approved | Start date: | 09/27/2020 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | Miroslav Fidler | % Done: | 0% | |
| Category: | CtrlLib | Spent time: | - | |
| Target version: | Release 2020.2 - NTH |
Description
It seems that FileSelButton is missing one big feather - tooltip. I highly suggest to change following line (CtrlLib/CtrlUtil.cpp):
button.SetImage(CtrlImg::right_arrow()).Tip(t_("Select path.."));
.. - means that dialog will be open.
Well, TheIDE code is not perfect and sometimes this class is use and sometimes it is added by hand. Anyway, after applying we should refactor TheIDE to use only FileSelButton.
FileSelButtonTip.diff 
(1.15 KB)
History
#1 Updated by Zbigniew Rebacz over 3 years ago
- Description updated (diff)
#2 Updated by Zbigniew Rebacz over 3 years ago
This require more work - probably adding virtual method Tip() would solve the issue.
#3 Updated by Miroslav Fidler over 3 years ago
IMO not a good idea. Better to add tip on per usage base in client code ("Open new source file..")
#4 Updated by Zbigniew Rebacz over 3 years ago
- Status changed from Patch ready to Rejected
- Assignee changed from Miroslav Fidler to Zbigniew Rebacz
#5 Updated by Zbigniew Rebacz over 3 years ago
- Status changed from Rejected to New
- Assignee changed from Zbigniew Rebacz to Miroslav Fidler
Anyway the Tip method doesn't work for FileSelButton. You need to set it for FrameRight<Button> button; not for Ctrl. Mirek can you add such functionality?
#6 Updated by Zbigniew Rebacz over 3 years ago
- File FileSelButtonTip.diff added
- Status changed from New to Patch ready
Patch ready...
#7 Updated by Miroslav Fidler over 3 years ago
OK, applied. Thanks for the cleanup too :)
#8 Updated by Miroslav Fidler over 3 years ago
- Status changed from Patch ready to Approved