Feature #2078

FileSelButton should display "Select path.." tip

Added by Zbigniew Rebacz about 4 years ago. Updated about 4 years ago.

Status:ApprovedStart date:09/27/2020
Priority:NormalDue date:
Assignee:Miroslav Fidler% Done:

0%

Category:CtrlLibSpent time:-
Target version:Release 2020.2 - NTH

Description

It seems that FileSelButton is missing one big feather - tooltip. I highly suggest to change following line (CtrlLib/CtrlUtil.cpp):

button.SetImage(CtrlImg::right_arrow()).Tip(t_("Select path.."));

.. - means that dialog will be open.

Well, TheIDE code is not perfect and sometimes this class is use and sometimes it is added by hand. Anyway, after applying we should refactor TheIDE to use only FileSelButton.

FileSelButtonTip.diff Magnifier (1.15 KB) Zbigniew Rebacz, 09/28/2020 08:51 PM

History

#1 Updated by Zbigniew Rebacz about 4 years ago

  • Description updated (diff)

#2 Updated by Zbigniew Rebacz about 4 years ago

This require more work - probably adding virtual method Tip() would solve the issue.

#3 Updated by Miroslav Fidler about 4 years ago

IMO not a good idea. Better to add tip on per usage base in client code ("Open new source file..")

#4 Updated by Zbigniew Rebacz about 4 years ago

  • Status changed from Patch ready to Rejected
  • Assignee changed from Miroslav Fidler to Zbigniew Rebacz

#5 Updated by Zbigniew Rebacz about 4 years ago

  • Status changed from Rejected to New
  • Assignee changed from Zbigniew Rebacz to Miroslav Fidler

Anyway the Tip method doesn't work for FileSelButton. You need to set it for FrameRight<Button> button; not for Ctrl. Mirek can you add such functionality?

#6 Updated by Zbigniew Rebacz about 4 years ago

Patch ready...

#7 Updated by Miroslav Fidler about 4 years ago

OK, applied. Thanks for the cleanup too :)

#8 Updated by Miroslav Fidler about 4 years ago

  • Status changed from Patch ready to Approved

Also available in: Atom PDF