Bug #470

ValueMap::RemoveKey

Added by Miroslav Fidler over 7 years ago. Updated about 7 years ago.

Status:ApprovedStart date:05/15/2013
Priority:NormalDue date:
Assignee:Miroslav Fidler% Done:

0%

Category:CoreSpent time:-
Target version:-

470a_uppsrc.diff Magnifier - The diff file to apply for uppsrc directory (variant a) (1.51 KB) Sender Ghost, 08/16/2013 07:03 AM

470b_uppsrc.diff Magnifier - The diff file to apply for uppsrc directory (variant b) (1.28 KB) Sender Ghost, 08/16/2013 07:03 AM

History

#1 Updated by Sender Ghost about 7 years ago

Since, there are no concrete requirements, I made two variants of patches:
a) The ValueMap::RemoveKey removes keys and corresponding values.
b) The ValueMap::RemoveKey just uses Index::RemoveKey for keys.

#2 Updated by Miroslav Fidler about 7 years ago

  • Status changed from Patch ready to Ready for CR
  • Assignee changed from Miroslav Fidler to Sender Ghost

Thanks, I have started with a), but used "mass" removal Remove... (Vector is capable of removing sorted set of indicies in single operation).

#3 Updated by Sender Ghost about 7 years ago

  • Assignee changed from Sender Ghost to Miroslav Fidler

Miroslav Fidler wrote:

Vector is capable of removing sorted set of indicies in single operation.

Agreed, this is much faster.
The changes are ok.

#4 Updated by Miroslav Fidler about 7 years ago

  • Status changed from Ready for CR to Approved

Also available in: Atom PDF