Bug #526
GCC returns warning when compiling plugin/tif ("format not a string literal and no format arguments")
| Status: | Approved | Start date: | 09/22/2013 | |
|---|---|---|---|---|
| Priority: | Low | Due date: | ||
| Assignee: | Zbigniew Rebacz | % Done: | 100% | |
| Category: | General | Spent time: | - | |
| Target version: | - |
Description
It seems that gcc returns following warning: "format not a string literal and no format arguments [-Wformat-security]" when compiling plugin/tif. The solution is relatively easy. We need to replace dangerous command "TIFFError(TIFFFileName(tiff), emsg);" by more secure "TIFFError(TIFFFileName(tiff), "%s", emsg);". I enclose improved source file (plugin/tif/tifupp.cpp).
tifupp.cpp 
(33.9 KB)
History
#1 Updated by Zbigniew Rebacz over 11 years ago
- Status changed from New to Ready for QA
#2 Updated by Miroslav Fidler over 11 years ago
- Status changed from Ready for QA to Approved