Bug #598

Resolve issue with SetStdFont

Added by Miroslav Fidler almost 7 years ago. Updated almost 7 years ago.

Status:ApprovedStart date:12/04/2013
Priority:NormalDue date:
Assignee:Zbigniew Rebacz% Done:

0%

Category:-Spent time:-
Target version:-

Description

- does not work in Linux
- does not change the rich-text zoom
- InitRichTextZoom should probably rather use the minimum of vertical/horizontal zoom

History

#1 Updated by Miroslav Fidler almost 7 years ago

  • Status changed from New to Approved

#2 Updated by Zbigniew Rebacz almost 7 years ago

  • File SmallFont.png added
  • File SmallFontDescription.png added
  • File SystemApplication.png added
  • Status changed from Approved to New

Hello Mirek,

After this patch, fonts are extremely small compared to fonts used by system applications (Tested on Kubuntu 13.10). Can you check it?

In addition, I enclose three screenshots.

#3 Updated by Zbigniew Rebacz almost 7 years ago

  • Assignee set to Miroslav Fidler

#4 Updated by Miroslav Fidler almost 7 years ago

  • Assignee changed from Miroslav Fidler to Zbigniew Rebacz

I do not know, based on screenshots, menu font looks the same as in SystemApplication.png (perhaps only on first sight).

Font in Assist++ was always small, that is not related to StdFont, it is intentional (functions signatures are long, so the font is small so they fit).

#5 Updated by Zbigniew Rebacz almost 7 years ago

  • Assignee changed from Zbigniew Rebacz to Miroslav Fidler

I think we should use SansSerif insted of Arial in ChGtk (CtrlLib/ChGtk.cpp - line 85):

int fontname = Font::SANSSERIF;

int fontname = Font::ARIAL;

Font in Assist++ was always small, that is not related to StdFont, it is intentional (functions signatures are long, so the font is small so they fit).

My solution takes into account above situation.

#6 Updated by Zbigniew Rebacz almost 7 years ago

Something bad happened to my previous message. So, I decided to post it again.

I think we should use SansSerif insted of Arial in ChGtk (CtrlLib/ChGtk.cpp - line 85):

int fontname = Font::SANSSERIF;

instead of:
int fontname = Font::ARIAL;

Font in Assist++ was always small, that is not related to StdFont, it is intentional (functions signatures are long, so the font is small so they fit).

My solution takes into account above situation.

#7 Updated by Zbigniew Rebacz almost 7 years ago

  • Status changed from New to Patch ready

#8 Updated by Miroslav Fidler almost 7 years ago

ARIAL and SANSSERIF are synonyms (see Font class declaration).

In any case, it should not have any impact anyway, as 'fontname' is changed to the proper face in block starting at ChGtk.cpp 101. ARIAL is only the "default of defaults" there. But perhaps putting some DDUMPs there should reveal what is wrong (if anything - as I said I see nothing wrong with your screenshots).

#9 Updated by Miroslav Fidler almost 7 years ago

  • Assignee changed from Miroslav Fidler to Zbigniew Rebacz

#10 Updated by Miroslav Fidler almost 7 years ago

  • Status changed from Patch ready to In Progress

#11 Updated by Zbigniew Rebacz almost 7 years ago

  • Status changed from In Progress to Approved

Evrything works perfect on pure upp installation (X11 & GTK)!

#12 Updated by Zbigniew Rebacz over 6 years ago

  • File deleted (SystemApplication.png)

#13 Updated by Zbigniew Rebacz over 6 years ago

  • File deleted (SmallFontDescription.png)

#14 Updated by Zbigniew Rebacz over 6 years ago

  • File deleted (SmallFont.png)

Also available in: Atom PDF