Bug #652

ChStdSkin() & ChClassicSkin() should check the state of IsCompositedGui flag

Added by Zbigniew Rebacz almost 8 years ago. Updated over 7 years ago.

Status:ApprovedStart date:01/19/2014
Priority:NormalDue date:
Assignee:Miroslav Fidler% Done:

0%

Category:CtrlLibSpent time:-
Target version:-

Description

Personally, I think that we should always check the state of IsCompositedGui flag when theme is changed manualy. Code sample:

void ChStdSkin()
{
    ChSysInit();
    GUI_GlobalStyle_Write(GUISTYLE_XP); // <- Hard theme restart!
    GUI_PopUpEffect_Write(Ctrl::IsCompositedGui() ? GUIEFFECT_NONE : GUIEFFECT_SLIDE);
    ColoredOverride(CtrlsImg::Iml(), CtrlsImg::Iml());
}

P.S.
This check is important on POSIX platform (X11 & GTK)

P.S 2
ChGtk check this flag by default.

Ch.cpp Magnifier (1.94 KB) Zbigniew Rebacz, 01/29/2014 04:37 PM

History

#1 Updated by Miroslav Fidler over 7 years ago

  • Status changed from Patch ready to Approved

#2 Updated by Zbigniew Rebacz over 7 years ago

  • File Ch.cppMagnifier added
  • Status changed from Approved to Patch ready

It seems that in this bug report I forgot to include proper file.

What needs to be updated:
- "Hard theme restart!" comment isn't nessasary
- ChClassicSkin needs IsCompositedGui flag check

#3 Updated by Miroslav Fidler over 7 years ago

  • Status changed from Patch ready to Approved

Also available in: Atom PDF