Bug #761

EditorBar - MouseWheel should hide annotation in proper situation

Added by Zbigniew Rebacz over 7 years ago. Updated over 7 years ago.

Status:ApprovedStart date:04/24/2014
Priority:NormalDue date:
Assignee:Miroslav Fidler% Done:

0%

Category:CodeEditorSpent time:-
Target version:-

Description

I think we should also improve Editor Bar MouseWheel behavior. The current behavior is not good, because when you scroll, the annotation does not disappear. Moreover we should also reject the situations when scrolling is not possible.
re
For me the perfect solution is:

void EditorBar::MouseWheel(Point p, int zdelta, dword keyflags)
{
    if(editor) {
        int i = editor->GetScrollPos().y;
        editor->MouseWheel(p, zdelta, keyflags);
        if(i != editor->GetScrollPos().y)
            MouseLeave();
    }
}

EditorBar.cpp Magnifier - MouseMove instead of MouseLeave... (11.6 KB) Zbigniew Rebacz, 04/25/2014 09:37 PM

History

#1 Updated by Zbigniew Rebacz over 7 years ago

  • File deleted (EditorBar.cpp)

#2 Updated by Zbigniew Rebacz over 7 years ago

We should use MouseMove instead of MouseLeave...

Code:

void EditorBar::MouseWheel(Point p, int zdelta, dword keyflags)
{
    if(editor) {
        int i = editor->GetScrollPos().y;
        editor->MouseWheel(p, zdelta, keyflags);
        if(i != editor->GetScrollPos().y)
            MouseMove(p, keyflags);
    }
}

#3 Updated by Miroslav Fidler over 7 years ago

  • Status changed from Patch ready to Approved

Thanks!

Also available in: Atom PDF