Bug #797

Find in Files array dialog crashes IDE

Added by Zbigniew Rebacz almost 11 years ago. Updated almost 11 years ago.

Status:ApprovedStart date:06/23/2014
Priority:HighDue date:
Assignee:Zbigniew Rebacz% Done:

0%

Category:IDESpent time:-
Target version:-

Description

It seems that "Find in Files" array dialog crashes IDE in one certain situation. This situation occurs when you click on last line of Array Ctrl (ffound) - "n occurense(s) have been found". This is because in current implementation we don't check that user clicks on last line. We need definitely change this behaviour.

So, we should improve Ide::ShowFound method(ide/Errors.cpp - line 327):

void Ide::ShowFound()
{
    if(ffound.IsCursor() && ffound.GetCursor() < ffound.GetCount() - 1)
        GoToError(ValueTo<ErrorInfo>(ffound.Get("INFO")));
}

insted of

void Ide::ShowFound()
{
    if(ffound.IsCursor())
        GoToError(ValueTo<ErrorInfo>(ffound.Get("INFO")));
}

Errors.cpp Magnifier (9.37 KB) Zbigniew Rebacz, 06/23/2014 11:18 PM

History

#1 Updated by Miroslav Fidler almost 11 years ago

  • Status changed from Patch ready to Ready for QA
  • Assignee changed from Miroslav Fidler to Zbigniew Rebacz

In the end, I have used somewhat more complex fix....

#2 Updated by Zbigniew Rebacz almost 11 years ago

  • Status changed from Ready for QA to Approved

Also available in: Atom PDF