Bug #1405
EditorTabBar icons is loaded from operating system when package is open (Problem with TabBar serialization)
Status: | Approved | Start date: | 04/05/2016 | |
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | Zbigniew Rebacz | % Done: | 0% | |
Category: | IDE | Spent time: | - | |
Target version: | Release 2017.1 - NTH |
Description
Steps to reproduce (Make sure you have enabled editor icons):
1. Open project for example (ide)
2. Open several files
3. Close Ide
4. Open project again
Result: Files has got os icons.
History
#1 Updated by Zbigniew Rebacz about 9 years ago
- Assignee deleted (
Miroslav Fidler)
#2 Updated by Zbigniew Rebacz about 9 years ago
- Tracker changed from Feature to Bug
- Subject changed from EditorTabBar icons is not always displayed to EditorTabBar icons is loaded from operating system when package is open
- Description updated (diff)
- Assignee set to Zbigniew Rebacz
#3 Updated by Zbigniew Rebacz about 9 years ago
- File TabBarIconSerialization.diff
added
- Status changed from New to Patch ready
- Assignee changed from Zbigniew Rebacz to Miroslav Fidler
Well the icon serialization in TabBar doesn't exists. I think we should implement this. It is safe to add serialization parameter
#4 Updated by Zbigniew Rebacz about 9 years ago
- Subject changed from EditorTabBar icons is loaded from operating system when package is open to EditorTabBar icons is loaded from operating system when package is open (Problem with TabBar serialization)
#5 Updated by Miroslav Fidler about 9 years ago
- Status changed from Patch ready to Ready for QA
- Assignee changed from Miroslav Fidler to Zbigniew Rebacz
Serializing icons sounds sort of wasteful (and it would break all existing .cfg files), therefore I have opted to "fix" icons after loading tabbars instead. It is far from ideal, better solution would be perhaps to have some "Value->Icon" conversion callback in TabBar, but for theide, it works fine.
#6 Updated by Zbigniew Rebacz about 9 years ago
- Status changed from Ready for QA to Approved
It is nice to know that there is other better solution (Yes, serializing icons is (ambiguous option).