Task #1479

Core get ride of "extra ;" warning with pedantic mode

Added by Zbigniew Rebacz over 3 years ago. Updated 12 days ago.

Status:Patch readyStart date:06/25/2016
Priority:LowDue date:
Assignee:Miroslav Fidler% Done:

0%

Category:CoreSpent time:-
Target version:Release 2020.1 - NTH

Description

Compile with GCC and -Wpedantic to detects all warning related to "extra ;"

uppsrc.diff Magnifier - Proposed patch for uppsrc directory (since 13633 revision) (47 KB) Sender Ghost, 10/08/2019 04:59 PM

uppsrc_excluded_macros.diff Magnifier - Proposed patch for uppsrc directory (excluded changes for macros, since 13635 revision) (18 KB) Sender Ghost, 10/09/2019 01:41 PM

History

#1 Updated by Zbigniew Rebacz over 3 years ago

  • Tracker changed from Bug to Task

#2 Updated by Zbigniew Rebacz almost 3 years ago

  • Target version changed from Release 2017.1 - NTH to Release 2017.2 - NTH

#3 Updated by Zbigniew Rebacz almost 2 years ago

  • Target version changed from Release 2017.2 - NTH to Release 2018.1 - NTH

#4 Updated by Zbigniew Rebacz over 1 year ago

  • Target version changed from Release 2018.1 - NTH to Release 2019.1 - NTH

#5 Updated by Zbigniew Rebacz 5 months ago

  • Target version changed from Release 2019.1 - NTH to Release 2019.2 - NTH

#6 Updated by Sender Ghost about 1 month ago

The GCC 8.3.0 compiler identified following cases with extra ';' character:

namespace * {*};
extern "C" {*};
INITIALIZE(*);
INITBLOCK {*};
rval_default(*);
CH_VALUE(*);
CH_IMAGE(*);
CH_COLOR(*);
CH_INT(*);
NTL_MOVEABLE(*);
SVO_FN(*);
VALUE_XMLIZE(*);
__Expand(*);
INI_TYPE(*);
INI_BOOL(*);
INI_INT(*);
INI_STRING(*);

and where INI_TYPE define was used manually:

INI_INT64(*);
INI_DOUBLE(*);

Patch attached.
Please use "svn patch" (or patch, etc.) utility to apply patches, because current (at 13633 revision) version of TheIDE's "Assist -> Display/apply patch.." function doesn't recognize "\ No newline at end of file" line(s) in patches, created by diff, "git diff" or "svn diff" programs.

#7 Updated by Sender Ghost about 1 month ago

  • Status changed from New to Patch ready

#8 Updated by Miroslav Fidler about 1 month ago

Yeah, well, but I would like to actually have ';' after many of these macros, for two reasons:

- it is more readable (; being a natural item ending character in C++)
- futureproofing - it is not unlikely that some day in the future implementation changes. well, unlikely, but still

Maybe we should instead find a way how to require ';' there?

#9 Updated by Sender Ghost about 1 month ago

I think, the namespace and extern are valid cases. Possible to create another patch, which excludes changes for macros.

#10 Updated by Sender Ghost about 1 month ago

Attached new patch with excluded changes for macros.

#11 Updated by Zbigniew Rebacz 12 days ago

  • Target version changed from Release 2019.2 - NTH to Release 2020.1 - NTH

Also available in: Atom PDF