Feature #502

High resolution icons for TheIDE

Added by Zbigniew Rebacz over 6 years ago. Updated over 6 years ago.

Status:ApprovedStart date:08/28/2013
Priority:LowDue date:
Assignee:Zbigniew Rebacz% Done:

0%

Category:IDESpent time:-
Target version:-

ide.iml (282 KB) Zbigniew Rebacz, 08/30/2013 02:15 PM

SystemBar.png (43.8 KB) Zbigniew Rebacz, 08/30/2013 02:15 PM

History

#1 Updated by Zbigniew Rebacz over 6 years ago

  • Category set to IDE

#2 Updated by Zbigniew Rebacz over 6 years ago

  • Assignee set to Zbigniew Rebacz

#3 Updated by Miroslav Fidler over 6 years ago

  • Status changed from Ready for QA to Patch ready

#4 Updated by Miroslav Fidler over 6 years ago

  • Status changed from Patch ready to Approved

#5 Updated by Zbigniew Rebacz over 6 years ago

It seems that this code dosen't work (ide.cpp - line 746):


switch(state_icon) {
case 1: Icon(IdeImg::IconDebugging(), IdeImg::IconDebuggingLarge()); break;
case 2: Icon(IdeImg::IconRunning(), IdeImg::IconRunningLarge()); break;
case 3: Icon(IdeImg::IconBuilding(), IdeImg::IconBuildingLarge()); break;
default: Icon(IdeImg::Package(), IdeImg::PackageLarge());
}

This code forces small icons not large. Why just not write:


switch(state_icon) {
case 1: Icon(IdeImg::IconDebuggingLarge()); break;
case 2: Icon(IdeImg::IconRunningLarge()); break;
case 3: Icon(IdeImg::IconBuildingLarge()); break;
default: Icon(IdeImg::PackageLarge());
}

Moreover, I enclosed updated ide.iml file (small icon fix) and exemplary screenshot.

P.S.
It can be also bug in following method: "TopWindow& Icon(const Image& smallicon, const Image& largeicon)".

#6 Updated by Zbigniew Rebacz over 6 years ago

  • Status changed from Rejected to New

#7 Updated by Zbigniew Rebacz over 6 years ago

Large icon also doesn't work in SelectPkg.cpp (line 14):

Icon(IdeImg::Package(), IdeImg::PackageLarge());

The reason is the same.

#8 Updated by Zbigniew Rebacz over 6 years ago

Finally, I diagnosed what is wrong. The problem is that TopWindow::SyncCaption() (From CtrlCore/X11Top.cpp - line 163) dosen't use "largeicon" variable. What I would like to said is that largeicon is Windows only feature.

We have two choises. First, we can use method "TopWindow& Icon(const Image& m)" with large icon as parametr. Second, we can implement largeicon feature under X11. The second option is more difficult than first option and I don't know how to implement it :(.

#9 Updated by Zbigniew Rebacz over 6 years ago

  • Status changed from New to Approved

This feature is definitely finished.

Also available in: Atom PDF