Bug #565

HelpWindow should have symmetric margins. (Quality fix)

Added by Zbigniew Rebacz almost 7 years ago. Updated almost 7 years ago.

Status:ApprovedStart date:11/05/2013
Priority:LowDue date:
Assignee:Miroslav Fidler% Done:

100%

Category:CtrlLibSpent time:-
Target version:-

Description

I have noticed that left right margin of HelpWindow look strange. Let's take a look at HelpWindow margin code (CtrlLib/Help.cpp - line 309):

view.Margins(Rect(12, 12, 2, 2));

In my opinion we should use only left and right margins:

view.Margins(Rect(12, 0, 12, 0));

In this case top and bottom margins isn't necessary for whole view. This behaviour will be more similar for what web browsers are doing.

At the end, I enclose improved source file.

Help.cpp Magnifier (5.77 KB) Zbigniew Rebacz, 11/05/2013 02:46 PM

History

#1 Updated by Zbigniew Rebacz almost 7 years ago

  • Assignee changed from Zbigniew Rebacz to Miroslav Fidler

#2 Updated by Miroslav Fidler almost 7 years ago

  • Status changed from Ready for QA to Approved

Also available in: Atom PDF