Bug #796

"Help & Topis (in window)" menu entry shouldn't use help icon

Added by Zbigniew Rebacz about 7 years ago. Updated about 7 years ago.

Status:ApprovedStart date:06/23/2014
Priority:NormalDue date:
Assignee:Miroslav Fidler% Done:

0%

Category:IDESpent time:-
Target version:-

Description

Two help icons next to each other look strange in IDE bar...

In ide/idebar.cpp (line 574):

menu.Add(AK_BROWSETOPICS_WIN, IdeImg::help(), THISBACK(ShowTopicsWin));

Should be

menu.Add(AK_BROWSETOPICS_WIN, THISBACK(ShowTopicsWin));

IdeBar.png (359 KB) Zbigniew Rebacz, 06/23/2014 08:07 PM

ide.iml - Added help_win & help_win_large (287 KB) Zbigniew Rebacz, 06/24/2014 04:27 PM

IdeBarUpdate.png (249 KB) Zbigniew Rebacz, 06/24/2014 04:27 PM

IdeBarUpdate.png - Comp image (249 KB) Zbigniew Rebacz, 06/24/2014 04:27 PM

History

#1 Updated by Miroslav Fidler about 7 years ago

  • Status changed from Patch ready to Ready for QA
  • Assignee changed from Miroslav Fidler to Zbigniew Rebacz

#2 Updated by Zbigniew Rebacz about 7 years ago

I think we can make more accurete icon to this situation. The task here is to show that help is really in separate window. I made two new icons "help_win" & "help_win_large".

If you decided to aprrove this solution you will also need to patch ide/Help.cpp (Here we need to add support for new icons normal & large to help window):

void Ide::ShowTopicsWin()
{
    windoc.Icon(IdeImg::help_win(), IdeImg::help_win_large());
    if(windoc.IsOpen())
        windoc.SetForeground();
    else {
        windoc.SyncDocTree();
        windoc.GoTo(sTopicHome);
        windoc.OpenMain();
    }
}

P.S.
I am sure that ShowTopicsWin is not the best place for setting icon for window. In my opinion we should set icon, only once per window life.

#3 Updated by Miroslav Fidler about 7 years ago

  • Status changed from Patch ready to Approved

Also available in: Atom PDF