Bug #796
"Help & Topis (in window)" menu entry shouldn't use help icon
| Status: | Approved | Start date: | 06/23/2014 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | Miroslav Fidler | % Done: | 0% | |
| Category: | IDE | Spent time: | - | |
| Target version: | - |
Description
Two help icons next to each other look strange in IDE bar...
In ide/idebar.cpp (line 574):
menu.Add(AK_BROWSETOPICS_WIN, IdeImg::help(), THISBACK(ShowTopicsWin));
Should be
menu.Add(AK_BROWSETOPICS_WIN, THISBACK(ShowTopicsWin));
History
#1 Updated by Miroslav Fidler over 10 years ago
- Status changed from Patch ready to Ready for QA
- Assignee changed from Miroslav Fidler to Zbigniew Rebacz
#2 Updated by Zbigniew Rebacz over 10 years ago
- File ide.iml added
- File IdeBarUpdate.png added
- File IdeBarUpdate.png added
- Status changed from Ready for QA to Patch ready
- Assignee changed from Zbigniew Rebacz to Miroslav Fidler
I think we can make more accurete icon to this situation. The task here is to show that help is really in separate window. I made two new icons "help_win" & "help_win_large".
If you decided to aprrove this solution you will also need to patch ide/Help.cpp (Here we need to add support for new icons normal & large to help window):
void Ide::ShowTopicsWin()
{
windoc.Icon(IdeImg::help_win(), IdeImg::help_win_large());
if(windoc.IsOpen())
windoc.SetForeground();
else {
windoc.SyncDocTree();
windoc.GoTo(sTopicHome);
windoc.OpenMain();
}
}
P.S.
I am sure that ShowTopicsWin is not the best place for setting icon for window. In my opinion we should set icon, only once per window life.
#3 Updated by Miroslav Fidler over 10 years ago
- Status changed from Patch ready to Approved