U++

I think it will be nice if LocalProcess & AProcess will posses one very usful method. It is "void WaitForExit()" method. The main goal of it is to wait until the process is finished.

Implementation:

void LocalProcess::WaitForExit()
{
    if(!IsRunning())
        return;

    bool isSuccess = false;
#ifdef PLATFORM_POSIX
    int status;
    if(waitpid(pid, &status, 0) == pid) {
        isSuccess = true;
        pid = 0;
    }
#endif
#ifdef PLATFORM_WIN32
    if(WaitForSingleObject(hProcess, INFINITE)) {
        isSuccess = true;
        hProcess = NULL;
    }
#endif
    if(isSuccess)
        CloseInputAndOutput();
}

Of course this patch also intoduce new private method "CloseInputAndOutput" which target is to close all pipes related to LocalProcess. (All implementation is included in source files).

Test case (I tested this solution with valgrind to make sure that we don't have any memory leaks):

#include <Core/Core.h>

using namespace Upp;

void startApp(LocalProcess& process) {
    #ifdef PLATFORM_POSIX
        process.Start("/usr/bin/xterm");
    #endif
    #ifdef PLATFORM_WIN32
        process.Start("E:\\Programy\\Notepad++\\notepad++.exe");
    #endif
}

CONSOLE_APP_MAIN {
    for (int i = 0; i < 1; i++) {
        // Test if "WaitForExit" works.
        LocalProcess myProcess;
        startApp(myProcess);
        myProcess.WaitForExit();

        // Test if we can reuse the same instance of LocalProcces for new task.
        startApp(myProcess);
        myProcess.WaitForExit();
    }
}